Repository navigation
ci(engine-review): allow antigravity engine prefix - #3646
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
|
PetrefiedThunder
left a comment
There was a problem hiding this comment.
Codex review of 5a1b53c. One-line add of antigravity to ALLOWED_ENGINES in engine-review-pass.yml.
- Format: correct. It is lowercase and has no separators. The author engine is the lowercased branch prefix before
/, and the reviewer engine is matched by[A-Za-z0-9._-]+and lowercased before the Set lookup. #3626, #3627 and #3628 useantigravity/...branches, so they now pass the author check. - Self-PASS: a marker whose engine equals the branch-prefix engine does not count, so
REVIEW: PASS antigravityon an antigravity/ branch is ignored. Note that the file itself says all engines post through one shared account, so this is an audit trail, not a cryptographic gate. That is unchanged by this PR. - #3637 (still OPEN, unmerged) deletes engine-review-pass.yml and carries its own ALLOWED_ENGINES copy in pr-guards.yml (around L1212), which does NOT include
antigravity. Whichever lands second must carry it: if #3646 lands first, #3637 needsantigravityadded to pr-guards.yml when it rebases, or the regression returns silently. - actionlint: clean.
REVIEW: PASS codex 5a1b53c
PR Blocker ChecklistHead SHA: Status: Ready
|
Why
Engine Review Pass (
.github/workflows/engine-review-pass.yml) takes the author engine from the branch prefix and checks it againstALLOWED_ENGINES.antigravityis missing, so Antigravity's PRs #3626, #3627 and #3628 (antigravity/...branches) fail with:Their valid cross-engine PASS markers can never count until the prefix is allowed.
Change
One line: add
'antigravity'toALLOWED_ENGINES, same format as the existing entries. No other change.Verification
actionlint .github/workflows/engine-review-pass.ymlpasses.Note
Low Risk
Single allowlist entry in CI workflow only; no application or security logic changes.
Overview
Engine Review Pass now treats
antigravityas a valid engine name, alongside existing entries likeclaudeandgemini.PRs on branches prefixed with
antigravity/were failing the workflow’s author-engine check before any cross-engineREVIEW: PASSmarkers could count. That prefix is now allowed inALLOWED_ENGINES, so Antigravity-authored PRs can pass the check when another engine posts a valid PASS for the current head SHA.Reviewed by Cursor Bugbot for commit 5a1b53c. Bugbot is set up for automated code reviews on this repo. Configure here.