Skip to content

ci(engine-review): allow antigravity engine prefix - #3646

Merged
PetrefiedThunder merged 1 commit into
mainfrom
gemini/engine-allowlist-antigravity
Oct 26, 2026
Merged

PetrefiedThunder merged 1 commit into
mainfrom
gemini/engine-allowlist-antigravity

Conversation

@PetrefiedThunder

@PetrefiedThunder PetrefiedThunder commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Engine Review Pass (.github/workflows/engine-review-pass.yml) takes the author engine from the branch prefix and checks it against ALLOWED_ENGINES. antigravity is missing, so Antigravity's PRs #3626, #3627 and #3628 (antigravity/... branches) fail with:

Invalid author engine. Please use an engine branch prefix such as gemini/ or claude/.

Their valid cross-engine PASS markers can never count until the prefix is allowed.

Change

One line: add 'antigravity' to ALLOWED_ENGINES, same format as the existing entries. No other change.

Verification


Note

Low Risk
Single allowlist entry in CI workflow only; no application or security logic changes.

Overview
Engine Review Pass now treats antigravity as a valid engine name, alongside existing entries like claude and gemini.

PRs on branches prefixed with antigravity/ were failing the workflow’s author-engine check before any cross-engine REVIEW: PASS markers could count. That prefix is now allowed in ALLOWED_ENGINES, so Antigravity-authored PRs can pass the check when another engine posts a valid PASS for the current head SHA.

Reviewed by Cursor Bugbot for commit 5a1b53c. Bugbot is set up for automated code reviews on this repo. Configure here.

Engine Review Pass derives the author engine from the branch prefix and rejects antigravity/ branches with 'Invalid author engine' (#3626, #3627, #3628).
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
regengine Ready Ready Preview Oct 26, 2026 12:34pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T12:37:52.129162Z 5a1b53c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d3c5ed6 and 5a1b53c.

Files selected for processing: 1
  • .github/workflows/engine-review-pass.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

The engine allowlist now includes antigravity. Existing validation accepts it as an author branch prefix and reviewer engine.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to 5a1b5

The allowlist change is valid and introduces no identified merge-blocking risk.

Architecture risk: Low · up to 5a1b5

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/engine-review-pass.yml: Added antigravity to ALLOWED_ENGINES, allowing it as an author branch prefix and reviewer engine in the existing validation.
Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the problem, the one-line change, affected pull requests, and verification. However, it does not use the required template sections for Summary, Type of Change, Test Plan, Che… Update the description to include all required template sections. Mark the applicable Type of Change and Test Plan items, complete the Checklist, and state related issues or that none apply.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the CI change: allowing the antigravity engine prefix.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the problem, the one-line change, affected pull requests, and verification. However, it does not use the required template sections for Summary, Type of Change, Test Plan, Checklist, or Related Issues.

Resolution

Update the description to include all required template sections. Mark the applicable Type of Change and Test Plan items, complete the Checklist, and state related issues or that none apply.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@PetrefiedThunder PetrefiedThunder left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex review of 5a1b53c. One-line add of antigravity to ALLOWED_ENGINES in engine-review-pass.yml.

  • Format: correct. It is lowercase and has no separators. The author engine is the lowercased branch prefix before /, and the reviewer engine is matched by [A-Za-z0-9._-]+ and lowercased before the Set lookup. #3626, #3627 and #3628 use antigravity/... branches, so they now pass the author check.
  • Self-PASS: a marker whose engine equals the branch-prefix engine does not count, so REVIEW: PASS antigravity on an antigravity/ branch is ignored. Note that the file itself says all engines post through one shared account, so this is an audit trail, not a cryptographic gate. That is unchanged by this PR.
  • #3637 (still OPEN, unmerged) deletes engine-review-pass.yml and carries its own ALLOWED_ENGINES copy in pr-guards.yml (around L1212), which does NOT include antigravity. Whichever lands second must carry it: if #3646 lands first, #3637 needs antigravity added to pr-guards.yml when it rebases, or the regression returns silently.
  • actionlint: clean.

REVIEW: PASS codex 5a1b53c

@PetrefiedThunder
PetrefiedThunder enabled auto-merge (squash) October 26, 2026 13:02
@github-actions

Copy link
Copy Markdown
Contributor

PR Blocker Checklist

Head SHA: 5a1b53cc3093d3f55dda3838760b8bf5b6a2fd3c

Status: Ready

  • All review threads resolved
  • No reviews requesting changes
  • No blocked review engines

@github-actions github-actions Bot added ci agent:infra Issues found by Bot-Infra agent labels Oct 26, 2026
@PetrefiedThunder
PetrefiedThunder merged commit 425dc7f into main Oct 26, 2026
47 of 53 checks passed
@PetrefiedThunder
PetrefiedThunder deleted the gemini/engine-allowlist-antigravity branch October 26, 2026 14:43

This branch was successfully deployed

1 active deployment
Preview — 5a1b53cc Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:infra Issues found by Bot-Infra agent ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant