Repository navigation
ci: limit copy and factory-local PR triggers to main - #3640
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
|
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS pi d0f95b6
- Required checks: branch protection on main requires only CI Status Gate, PR Gate: Backend, PR Gate: Frontend and PR Gate: Workflow Contract. Copy gate, Copy rules report and factory-local CI are not required, and no other workflow depends on them (the copy-lint-tools-grade-verdicts job lives in pr-gate.yml and is unaffected). Restricting them to PRs into main cannot leave a required check missing. The one open PR with a non-main base, #3612 into kimi/edi-preserve-event-time, will simply skip these advisory checks, and they run again when that work targets main.
- #3637: it adds a concurrency block below the paths list in copy-gate.yml, while this PR adds a branches line above paths. The hunks don't overlap and the two changes are compatible, whichever merges first.
- YAML: all three files parse, and actionlint passes on copy-gate.yml, copy-lint.yml and factory-local-ci.yml at this head.
PR Blocker ChecklistHead SHA: Status: Ready
|
Implements GitHub Ops baseline (
/workspace/github-ops/baseline.md) ranked move 2 (stop double runs:pushon main,pull_requestfor PRs into main).Change
copy-gate.yml,copy-lint.yml,factory-local-ci.yml: addbranches: [main]underpull_request(existing path filters unchanged). These were the only path-filtered PR workflows without a base-branch filter, so stacked PRs (base = another feature branch) ran them twice: once on the stacked PR and again when retargeted to main.Already done on main (no change)
pushrestricted to main/develop andpull_requestto main, with path filters.security.ymlandsupply-chain.ymlkeep running on all PR bases on purpose (secrets and dependency scans on stacked PRs).Verify
actionlinton the three files passes; pre-commit passes.CI Status Gate,PR Gate: Backend,PR Gate: Frontend,PR Gate: Workflow Contract).frontend/**no longer starts Copy gate or the Copy rules report.Note
Low Risk
Workflow trigger-only change with no application or security logic; slightly narrows when optional CI runs on stacked PRs.
Overview
Aligns Copy gate, Copy rules report, and factory-local CI with the repo’s GitHub Ops baseline so path-filtered workflows only run on PRs into
main, matching workflows like backend-ci and frontend-ci.Each of the three workflow files adds
branches: [main]underpull_request; existing path filters andpushtriggers onmainare unchanged. Stacked PRs whose base is another feature branch will no longer fire these jobs until the PR targetsmain, avoiding duplicate runs when the same changes are exercised twice.Reviewed by Cursor Bugbot for commit d0f95b6. Bugbot is set up for automated code reviews on this repo. Configure here.