Repository navigation
fix(suppliers): refresh late CTE records when agreed hours change - #3610
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
PR Blocker ChecklistHead SHA: Status: Ready
|
|
Vercel preview: https://regengine-mudwkbw12-petrefiedthunders-projects.vercel.app Access is via Vercel login (Deployment Protection). |
✅ Bundle Size Report
Bundle is within the 10.0MB limit. |
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS grok 47f6b60
Remounting late_cte MetricRow when agreed_sending_hours changes correctly clears stale drilldown state; regression test covers open, hours change, old id gone, reopen loads new id. Main merge is clean (no conflict markers; PR still only touches data-quality.tsx and its test). Supplier view remains read-only. CI was still mostly queued on this head at review time; re-check before merge.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
The agreed sending time feature merged in #3575. If the agreed hours changed while a late CTE record list was open, that list could keep showing records from the previous agreement. The late CTE row now resets when the agreed hours change, and reopening it loads records for the current agreement.
The regression test uses generated record identifiers and checks that the prior record disappears before the current record is loaded. The supplier view remains read only, as it is on main.
Verification
The focused frontend suite passed: 16 tests. ESLint, the staged secret scan, and the diff check passed. Type checking reported only the existing error in
src/instrumentation.ts(26,5)aboutqueuesinDataCollection.This PR changes two frontend files. It does not apply a database migration. The production migration status of #3575 was not verified here.
Note
Low Risk
Small supplier dashboard UI fix with no API or auth changes; behavior is covered by a focused component test.
Overview
Fixes a stale UI bug where an open late CTE “View records” list could still show rows from the previous agreed sending time after the summary updated.
The late CTE row’s React
keynow includesagreed_sending_hours(orunset), so when hours change the row remounts and its drilldown state resets; reopening loads records for the current agreement. Tests add alateRecordItemhelper with realistic event/received timestamps and a regression case that rerenders with new hours, asserts the old record id disappears, and verifies a fresh fetch on reopen.Reviewed by Cursor Bugbot for commit 47f6b60. Bugbot is set up for automated code reviews on this repo. Configure here.