Repository navigation
fix(copy): drop walkthrough em dash and prune stale copy-lint baseline - #3582
PetrefiedThunder wants to merge 3 commits into
Conversation
Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title names the two changes in the PR: removing the em dash from the walkthrough copy and pruning the stale copy-lint baseline. It is specific and matches the raw summary and objectives. It is a s… Description check The description follows the template's main sections in substance. It gives a summary of the walkthrough wording change and the baseline update, with verification details (copy gate exit 0, copy-lint … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the two changes in the PR: removing the em dash from the walkthrough copy and pruning the stale copy-lint baseline. It is specific and matches the raw summary and objectives. It is a single line, but at 70 characters it is slightly long and uses a conventional-commit prefix.
Full details: Description check
-
Explanation
The description follows the template's main sections in substance. It gives a summary of the walkthrough wording change and the baseline update, with verification details (copy gate exit 0, copy-lint tests 16/16). It does not fill in the template's Summary bullet format, the Type of Change checkboxes, the Test Plan checkboxes, the Checklist, or the Related Issues section. The description does not state the type of change, and it does not say which test option applies. It also does not link a related issue, although it refers to
#3575for wording.Resolution
Optionally tick the Type of Change box (Bug fix fits best), tick the applicable Test Plan items (for example, the copy-lint tests were run, so Unit tests updated may apply), complete the Checklist, and add
#3575or the failing main run under Related Issues.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
✅ Bundle Size Report
Bundle is within the 10.0MB limit. |
|
Vercel preview access note removed (A-2177 secret-hygiene cleanup). |
PetrefiedThunder
left a comment
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS muse e436256
One commit on top of main. walkthrough/page.tsx replaces the em dash with two sentences, and the meaning is unchanged. Comparing scripts/copy-lint/baseline.json against its parent: 32 entries removed, none added, no counts raised. Only stale entries are pruned, so the ratchet only tightens. Copy gate is green, and the only failing check is Engine Review Pass, which is waiting on this review. No data added.
PR Blocker ChecklistHead SHA: Status: Ready
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
PetrefiedThunder
left a comment
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS grok d54b17c
Full review (no earlier grok review). Diff vs main 2eaad75:
- frontend/src/app/docs/walkthrough/page.tsx: replaces the em dash with a period and a new sentence. Copy is accurate.
- scripts/copy-lint/baseline.json: 37 entries lowered or removed, none raised or added (checked key by key).
- d54b17c is a clean merge of e436256 and main 2eaad75: merge-tree tree 344481b3 matches, remerge-diff empty.
No fake data introduced.
Posted with C.Lee's approval (10:37 PM PT).
Resolve scripts/copy-lint/baseline.json by taking main's baseline and regenerating it with --update-baseline. Main already carries the dashless walkthrough copy and the pruned baseline from #3574. Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
|
Superseded by #3574, which already brought this copy gate fix onto main (0 file changes versus main after the main merge). Closed per C.Lee's approval; the branch is kept. |
Copy gate fails on main (f973979): docs/walkthrough/page.tsx em-dash went up (baseline 0, actual 1), plus stale baseline entries.
Auto-merge not armed.
Note
Low Risk
Documentation copy and lint baseline housekeeping only; no runtime, auth, or data-path changes.
Overview
Unblocks the copy gate on main by fixing walkthrough prose and refreshing the copy-lint baseline.
Walkthrough (
frontend/src/app/docs/walkthrough/page.tsx): rewrites the flow intro to drop an em dash (restores wording aligned with #3575—period break: “one shipping event. That is three events in…”).Baseline (
scripts/copy-lint/baseline.json): regenerated with--update-baselineso only stale counts are pruned (per PR: 32 removed, 5 lowered; no new or raised allowances).Reviewed by Cursor Bugbot for commit cd07b64. Bugbot is set up for automated code reviews on this repo. Configure here.