fix(ci): Engine Review Pass follow-ups from #3577 review by PetrefiedThunder · Pull Request #3581 · regengine/RegEngine

PetrefiedThunder · 2026-10-25T03:42:39Z

Summary

Follow-up to #3577 (merged as 0b8ddf3) for its open review threads:

Rerun Engine Review Pass on issue_comment: deleted, so removing a marker comment updates the head status.
Order issue-comment markers by updated_at, so editing an older comment to BLOCKED/FAIL is not overridden by an older PASS.
Accept uppercase hex in the marker SHA (it is already compared case-insensitively).

Type of Change

Bug fix
CI/CD or infrastructure

Test Plan

N/A (docs, config, etc.): YAML parses; the change is three lines in the workflow script.

Checklist

My code follows the existing patterns in the codebase
I have not introduced hardcoded secrets or credentials
If this PR adds a test that uses sys.modules[X] = stub, I justified it in the PR description
I have updated relevant documentation (if applicable)
My changes generate no new warnings or lint errors

Related Issues

Relates to #3577

Note

Low Risk
Small CI workflow script changes for audit-trail status only; no app runtime, auth, or data paths.

Overview
Engine Review Pass CI is tightened so head commit status stays accurate when review markers move via comments.

The workflow now runs on issue_comment deleted events, so removing a marker comment triggers a fresh pass and updates status. Issue comments are ordered by updated_at (falling back to created_at) when resolving the latest marker per engine, so editing an older comment to BLOCKED/FAIL is not beaten by a newer PASS that only predates the edit. The marker line regex also accepts uppercase hex in the 40-character SHA, matching the existing case-insensitive SHA comparison.

^{Reviewed by Cursor Bugbot for commit aa636aa. Bugbot is set up for automated code reviews on this repo. Configure here.}

- rerun on deleted issue comments so a removed marker updates the status - order comment markers by updated_at so an edit takes effect when made - accept uppercase hex in the marker SHA (compared case-insensitively)

vercel · 2026-10-25T03:42:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
regengine	Ready	Preview	Oct 25, 2026 3:44am UTC

chatgpt-codex-connector · 2026-10-25T03:42:50Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-25T03:43:30.643468Z	`aa636aa`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-25T03:43:00Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: regengine/RegEngine
Branch: pi/engine-review-pass-followups
File: .coderabbit.yaml
Commit: aa636aa
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 23d1bdf3-261f-4f53-b9f2-e60c98dbcd8f

Commits

Reviewing files that changed from the base of the PR and between f973979 and aa636aa.

Files selected for processing: 1

.github/workflows/engine-review-pass.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The workflow now runs for deleted issue comments. It uses updated_at as the normalized comment submission time, with created_at as a fallback. Review marker matching now accepts uppercase and lowercase hexadecimal characters in the 40-character SHA.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Minimal · up to aa636

No actionable merge-blocking risk remains in this workflow change.

Architecture risk: Low · up to aa636

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

observed — Modified behavior in .github/workflows/engine-review-pass.yml: The issue_comment trigger now includes deleted, so deletion events also run the workflow.
observed — Modified behavior in .github/workflows/engine-review-pass.yml: Normalized issue comments now use updated_at as their submission time, falling back to created_at; previously they always used created_at.
observed — Modified behavior in .github/workflows/engine-review-pass.yml: The marker regex now accepts uppercase as well as lowercase hexadecimal characters in the 40-character SHA.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies CI changes to Engine Review Pass as follow-ups to issue `#3577`. It is concise and related to the main changes.
Description check		The description follows the required template. It explains the three workflow changes, identifies the change type, provides a test plan, completes the checklist, and references issue `#3577`.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches: 💡 1

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-25T03:44:39Z

PR Blocker Checklist

Head SHA: aa636aaecf74c2ebbe13f9aef0dfa83d2cfb8984

Status: Ready

All review threads resolved
No reviews requesting changes
No blocked review engines

github-actions · 2026-10-25T03:45:04Z

Vercel preview access note removed (A-2177 secret-hygiene cleanup).
Access is via Vercel login (Deployment Protection).

PetrefiedThunder

REVIEW: PASS grok aa636aa

Diff: .github/workflows/engine-review-pass.yml only, 3 changes, matching the PR body.

issue_comment now also triggers on deleted, so removing a marker comment re-evaluates the head status. This is correct.
Issue-comment markers are now ordered by updated_at || created_at, so an edit takes effect at its edit time. This is correct for the stated case (an older PASS edited to FAIL). One known tradeoff: editing any text in an old PASS comment also moves it to the newest position, ahead of a later FAIL from the same engine. That is acceptable because the edit is an intentional reassertion.
The marker SHA regex now accepts uppercase hex, consistent with the existing case-insensitive comparison against headShaLower.
Note: the issue_comment trigger runs the workflow from the default branch, so these changes apply to comment-triggered runs only after merge (the same caveat as on #3577).
CI: everything required is green. Engine Review Pass fails only with "no passing review for current head", which is what this review addresses. visual-report is non-required and failed (unrelated to a workflow-only change).
No app code, no data, no secrets.

Posted with C.Lee's approval (9:22 PM PT).

fix(ci): Engine Review Pass follow-ups from #3577 review threads

aa636aa

- rerun on deleted issue comments so a removed marker updates the status - order comment markers by updated_at so an edit takes effect when made - accept uppercase hex in the marker SHA (compared case-insensitively)

vercel Bot deployed to Preview October 25, 2026 03:44

View deployment

github-actions Bot added ci agent:infra Issues found by Bot-Infra agent labels Oct 25, 2026

PetrefiedThunder commented Oct 25, 2026

View reviewed changes

PetrefiedThunder merged commit ec172b9 into main Oct 25, 2026
48 of 53 checks passed

PetrefiedThunder deleted the pi/engine-review-pass-followups branch October 25, 2026 04:23

Navigation Menu

Repository navigation

fix(ci): Engine Review Pass follow-ups from #3577 review - #3581

fix(ci): Engine Review Pass follow-ups from #3577 review#3581
PetrefiedThunder merged 1 commit into
mainfrom
pi/engine-review-pass-followups

PetrefiedThunder commented Oct 25, 2026 •

edited by cursor Bot

Loading

Uh oh!

vercel Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 25, 2026

Uh oh!

github-actions Bot commented Oct 25, 2026 •

edited by PetrefiedThunder

Loading

Uh oh!

PetrefiedThunder left a comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

PetrefiedThunder commented Oct 25, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Test Plan

Checklist

Related Issues

Uh oh!

vercel Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 25, 2026

PR Blocker Checklist

Status: Ready

Uh oh!

github-actions Bot commented Oct 25, 2026 • edited by PetrefiedThunder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

PetrefiedThunder commented Oct 25, 2026 •

edited by cursor Bot

Loading

vercel Bot commented Oct 25, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 25, 2026 •

edited

Loading

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

github-actions Bot commented Oct 25, 2026 •

edited by PetrefiedThunder

Loading