Repository navigation
test(ingest-epcis): data-free placeholders instead of invented EPCIS fixtures - #3566
Conversation
…ree placeholders Signed-off-by: Christopher Sellers <1@christophersellers.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the code changes and reports test results, but it omits the required Summary, Type of Change, Test Plan, Checklist, and Related Issues sections from the repository template. | Update the description to include all template sections. Mark applicable Type of Change and Test Plan items, complete the Checklist, and state related issues or N/A. |
-
Check name Status Explanation Title check The title clearly identifies the test change: replacing invented EPCIS fixtures with data-free placeholders. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Usage-based review receipt
- Mode: Continue automatically
- Reviewed files: 1
- Waived: $0.25 (charged $0.00)
- View usage details
Note
This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.
Comment @coderabbitai help to get the list of available commands.
PetrefiedThunder
left a comment
PetrefiedThunder
left a comment
There was a problem hiding this comment.
Formal review at 7ceedf2. The head matches and the branch is up to date with main.
Scope: one commit, touching only ingest-epcis.test.tsx (+6/-15).
SINGLE_EVENTbecomes{}.EPCIS_XMLnow has an empty<EventList />.- Both two-event lists are now
[{ ...SINGLE_EVENT }, { ...SINGLE_EVENT }].
It doesn't touch #3561's block: the sample import, the sample-link test and the epcisDocument body are unchanged. git merge-tree against #3561's head dd871b5 merges cleanly.
No invented data left in these fixtures: all of the dates (2026-03-01), the CBV bizStep URN and the XML event values are gone. The remaining mock strings are UI and error text (Missing bizLocation, EPCIS_XML_2.0) and an index or status code. They're not invented IDs or numbers.
The tests still check real behavior:
- A single object goes to
ingestEpcisEvent. - An array goes to
ingestEpcisBatchwith the exact events. .xmlgoes toingestEpcisXmlwith the exact XML.- Validate-only reports a failure for each event ("Event 2: ...").
- The non-matching endpoints are asserted not called.
Local run: vitest on ingest-epcis.test.tsx passed 10 of 10.
CI was still running at review time (5 pass, 28 pending, 6 skipping, none failing).
REVIEW: PASS codex 7ceedf2
PR Blocker ChecklistHead SHA: Status: Ready
|
✅ Bundle Size Report
Bundle is within the 10.0MB limit. |
|
Vercel preview access note removed (A-2177 secret-hygiene cleanup). |
…page and sample CSV - Resolve conflicts with #3543/#3561/#3566/#3572: take main's 'No data yet' case-studies page, main's walkthrough package details (EPCIS kept as Preview), main's EPCIS rejection tests, drop ARCHIVE_EXPORT_JOBS - InflowLabClient stays deleted (Inflow Lab retired by this PR) - Delete frontend/src/app/proof/recall-drill/page.tsx, its page test and frontend/public/samples/sample_recall_drill.csv (recall drill simulation removed per C.Lee, Oct 23) - routes.json: /proof/recall-drill moves to expectRedirectOr404 (same edit as #3551) - Drill simulator (Load Sample Data, generateSampleCSV) untouched; #3549 not merged so no baseline.json change Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
Real data only in tests. In frontend/src/tests/pages/ingest-epcis.test.tsx: SINGLE_EVENT (invented 2026-03-01 eventTime, offset, bizStep) becomes
{}; EPCIS_XML drops the invented ObjectEvent/eventTime and keeps an empty structural<EventList />; the two derived batches with edited eventTime become[{ ...SINGLE_EVENT }, { ...SINGLE_EVENT }]. Routing is shape-based (object → single, array → batch, .xml → XML endpoint), so passthrough, counts and endpoint routing are still exercised. Top-of-file sample import left untouched to avoid conflicting with #3561.Local: vitest ingest-epcis.test.tsx 10/10 passed.
Note
Low Risk
Test-only fixture cleanup in one Vitest file; no application or API behavior changes.
Overview
Replaces invented EPCIS field values in
ingest-epcis.test.tsxwith minimal placeholders so routing tests do not imply fake domain data.SINGLE_EVENTis now an empty{}(typed asRecord<string, unknown>), batch cases use two copies of that object instead of differingeventTimes, andEPCIS_XMLkeeps document structure with an empty<EventList />. A short comment documents that ingest routing depends on JSON shape (single object vs array vs.xmlfilename), not event contents. The sample file test still usessample_epcis_2.0.jsonfor realistic multi-event coverage.Reviewed by Cursor Bugbot for commit 7ceedf2. Bugbot is set up for automated code reviews on this repo. Configure here.