chore(scripts): remove seed_chaos_data.py fake-data seeder by PetrefiedThunder · Pull Request #3532 · regengine/RegEngine

PetrefiedThunder · 2026-10-23T15:18:28Z

Removes scripts/seed_chaos_data.py (synthetic chaos seed data) so fake data can't come back.

Deleted scripts/seed_chaos_data.py
Removed its 4 test references in tests/scripts/test_prod_default_guards.py (compose-host asserts, query-host override, main/cleanup guard tests)
Removed its .secrets.baseline entry
rg seed_chaos across the repo (docs, .github, scripts, tests): no other references remain

Tests: ruff clean; pytest tests/scripts/test_prod_default_guards.py 68 passed; pytest --collect-only tests 0 errors; detect-secrets-hook clean.

VS Code Codex reviews; do not merge (merge freeze).

Note

Low Risk
Deletion-only cleanup of an optional dev/chaos script and its tests; no runtime service or auth paths change.

Overview
Removes scripts/seed_chaos_data.py, the chaos-engineering helper that seeded tagged synthetic data into Neo4j (regulations/sections/requirements) and PostgreSQL (API keys, APScheduler jobs), with cleanup and non-localhost guards.

tests/scripts/test_prod_default_guards.py drops all coverage tied to that script (compose-host local checks, query-host override detection, main/--cleanup guard wiring, and remote-store refusal). Other script guard tests (diag_db, inflow verifier, create_test_api_key, regctl, smoke ingest) are unchanged.

.secrets.baseline no longer lists a detect-secrets finding for the deleted file.

^{Reviewed by Cursor Bugbot for commit 5ea2da3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Delete scripts/seed_chaos_data.py, its guard tests in tests/scripts/test_prod_default_guards.py, and its .secrets.baseline entry. No other callers, docs, or CI references remain. Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

vercel · 2026-10-23T15:18:35Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
regengine	Ignored	Preview	Oct 26, 2026 5:07am UTC

cursor · 2026-10-23T15:18:38Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 0f17cd44-6056-4c3e-96dc-c51b46e4287c)

chatgpt-codex-connector · 2026-10-23T15:18:41Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T15:19:36.497914Z	`e2b6706`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-23T15:18:53Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Last reviewed commit: faecc41
Latest commit, not reviewed: f3134ec

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: regengine/RegEngine
Branch: claude/remove-seed-chaos-data
File: .coderabbit.yaml
Commit: faecc41
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: a94544e0-d59a-4f05-9a93-de4b49183717

Commits

Reviewing files that changed from the base of the PR and between d9968e1 and faecc41.

Files selected for processing: 1

.secrets.baseline

Files with no reviewable changes: 1

.secrets.baseline

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

The pull request removes the chaos-data seeder, tests for its production-target guards, and its recorded Basic Auth Credentials finding from the secrets baseline.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · up to faecc

No actionable risk from this removal is identified. Observe the stated merge freeze before merging.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely describes the primary change: removal of the fake-data seeder.
Description check		The description explains the changes, lists affected files, reports test results, and notes the merge-freeze constraint. It does not reproduce every template heading, but it provides the core summary …
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the changes, lists affected files, reports test results, and notes the merge-freeze constraint. It does not reproduce every template heading, but it provides the core summary and test information needed for review.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-23T15:19:54Z

PR Blocker Checklist

Head SHA: f3134ec0180b2f1a7da83245e178ea56c96ea485

Status: Ready

All review threads resolved
No reviews requesting changes
No blocked review engines

PetrefiedThunder

REVIEW: PASS
Head e2b6706. Read-only review of the diff.

scripts/seed_chaos_data.py is deleted.
tests/scripts/test_prod_default_guards.py: the chaos checks are removed from test_compose_hostnames_count_as_local (:168-170 on main), along with test_chaos_seeder_refuses_query_host_override, test_chaos_main_refuses_remote_store_before_seeding and test_chaos_cleanup_still_guarded. The file has no remaining "chaos" references at this head, and the sys and pytest imports are still used (:16, :31).
.secrets.baseline: the only change removes the single scripts/seed_chaos_data.py entry, which belongs to the deleted file.
GitHub code search on main finds seed_chaos_data only in these three files, so no Makefile target, workflow, doc or import is left dangling.
The PR adds no lines, so it adds no invented data.
Tests were not run locally because the Mac battery is low. CI is the test gate.

github-actions · 2026-10-23T22:47:06Z

Branch updated with main

Main was merged into claude/remove-seed-chaos-data at the new head (5ea2da39a3517ddce640c0dcfce0c4893e336ff5).

Because merge commits created with GITHUB_TOKEN do not trigger workflows, a push to this branch or a manual CI re-run is needed for checks to run on it.

Last synced: 2026-10-24T02:11:43.965Z

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

PetrefiedThunder

REVIEW: PASS grok 5ea2da3

Delta review of #3532 from my previous PASS at fb6f6ab.

The only commit since then is 5ea2da3 ("chore(ci): retrigger checks"), a single-parent empty commit on top of fb6f6ab. Its tree (dc0f079fa61a) is identical to the previously reviewed tree; git diff fb6f6ab..5ea2da3 is empty. No content changed, so the prior PASS carries over to this head.

Posted with C.Lee's approval (Oct 23, 2026, 6:27 PM PT).

PetrefiedThunder · 2026-10-24T02:15:41Z

REVIEW: PASS pi 405b3e7
Delta since 5ea2da3 is only the github-actions main sync merge (clean, no manual conflict resolution; parents = prior PASS head + main), no PR code changes.

PetrefiedThunder

Delta review: since the last PASS, the only change is a clean sync merge of main with no manual conflict resolution.

REVIEW: PASS pi 405b3e7

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

PetrefiedThunder

REVIEW: PASS gemini 3214a7c

Deletes scripts/seed_chaos_data.py, its 4 guard tests plus 3 compose-host asserts in tests/scripts/test_prod_default_guards.py, and its stale .secrets.baseline entry. Remaining tests in that file cover diag_db/inflow verifier/regctl, unchanged.
git grep seed_chaos at this head: zero remaining references (no imports, docs, Makefile or workflow refs).
Recall drill simulations, Load Sample Data, generateSampleCSV, /proof/recall-drill, sample_recall_drill.csv untouched.
No public copy changed.
CI: required gates still queued/pending at review time; not run locally (Mac load ~28).

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

PetrefiedThunder

REVIEW: PASS gemini d9968e1

This is a delta review of the merge of main (f177122) into 3214a7c. The only files changed are .github/workflows/head-sha-check-guard.yml and vercel-preview-guard.yml, both identical to main. No code changed.

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

github-actions · 2026-10-25T08:45:17Z

Vercel preview access note removed (A-2177 secret-hygiene cleanup).
Access is via Vercel login (Deployment Protection).

…aos-data Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

PetrefiedThunder

Delta review of a7afb9e from the last engine PASS (gemini, d9968e1). Content is fine: the only commits since then are main merges (faecc41, a7afb9e), both with an empty remerge-diff, 0 non-merge commits not on main, and the PR diff is unchanged (.secrets.baseline hunk offset only; same 3 files, 577 deletions). Required checks are green and there are 0 unresolved threads.

Gate blocker: the branch is 1 commit behind main (e163b14, #3607). Also, no earlier codex PASS exists on this PR to carry forward. Merge main in again and I'll re-review the delta.

REVIEW: FAIL codex a7afb9e

PetrefiedThunder

Delta review: GitHub update-branch merge of main (2be76c9, #3551, which includes e163b14 #3607) only, empty remerge-diff, PR diff unchanged since d9968e1 (3 files, 577 deletions). 0 behind main, 0 unresolved threads. CI: required PR Gate checks pending at review time.

REVIEW: PASS codex f3134ec

vercel Bot had a problem deploying to Preview October 23, 2026 15:19 Failure

PetrefiedThunder commented Oct 23, 2026

View reviewed changes

Merge branch 'main' into claude/remove-seed-chaos-data

fb6f6ab

vercel Bot deployed to Preview October 23, 2026 22:49

View deployment

chore(ci): retrigger checks

5ea2da3

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

PetrefiedThunder commented Oct 24, 2026

View reviewed changes

PetrefiedThunder enabled auto-merge (squash) October 24, 2026 02:10

Merge branch 'main' into claude/remove-seed-chaos-data

405b3e7

vercel Bot deployed to Preview October 24, 2026 02:13

View deployment

PetrefiedThunder commented Oct 24, 2026

View reviewed changes

chore: merge main into claude/remove-seed-chaos-data

3214a7c

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

vercel Bot deployed to Preview October 24, 2026 05:09

View deployment

PetrefiedThunder commented Oct 24, 2026

View reviewed changes

Merge main into claude/remove-seed-chaos-data

d9968e1

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

PetrefiedThunder disabled auto-merge October 24, 2026 07:23

PetrefiedThunder commented Oct 24, 2026

View reviewed changes

PetrefiedThunder enabled auto-merge (squash) October 24, 2026 07:24

PetrefiedThunder mentioned this pull request Oct 25, 2026

ci(pr-gate): wait for slow Backend CI instead of timing out at 40 min #3595

Merged

PetrefiedThunder disabled auto-merge October 25, 2026 08:10

chore: merge main into PR #3532

faecc41

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

vercel Bot deployed to Preview October 25, 2026 08:13

View deployment

Merge remote-tracking branch 'origin/main' into claude/remove-seed-ch…

a7afb9e

…aos-data Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

PetrefiedThunder commented Oct 26, 2026

View reviewed changes

Merge branch 'main' into claude/remove-seed-chaos-data

f3134ec

PetrefiedThunder commented Oct 26, 2026

View reviewed changes

PetrefiedThunder merged commit a8b3e37 into main Oct 26, 2026
83 of 87 checks passed

PetrefiedThunder deleted the claude/remove-seed-chaos-data branch October 26, 2026 05:51

Conversation

PetrefiedThunder commented Oct 23, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Oct 23, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Blocker Checklist

Status: Ready

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Branch updated with main

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

PetrefiedThunder commented Oct 24, 2026

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 25, 2026 • edited by PetrefiedThunder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

PetrefiedThunder commented Oct 23, 2026 •

edited by cursor Bot

Loading

vercel Bot commented Oct 23, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 25, 2026 •

edited by PetrefiedThunder

Loading