You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
centralize browser wire-column dtype decoding for packed and split payloads
accept the existing default/explicit f32, u8, and u32 encodings
reject unknown dtypes with contextual errors before first-paint or incremental state/GL mutations
cover initial render, animation updates, append, LOD/drill, and density-sample paths
document the exhaustive wire contract and add regression/structural coverage
Why
Unknown four-byte dtype metadata previously fell through to Float32Array, allowing future or malformed values such as i32 or f64 to be silently misdecoded. The browser now fails loudly at the decode boundary instead.
Impact
Valid payload behavior is unchanged. Unsupported dtypes produce an actionable error containing the dtype and column/update context.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b1dd2ab9-2485-4bb6-95f9-a0ea3d9d5e0a
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
f32,u8, andu32encodingsWhy
Unknown four-byte dtype metadata previously fell through to
Float32Array, allowing future or malformed values such asi32orf64to be silently misdecoded. The browser now fails loudly at the decode boundary instead.Impact
Valid payload behavior is unchanged. Unsupported dtypes produce an actionable error containing the dtype and column/update context.
Fixes #434.
Validation
node js/build.mjsnpm run typecheckpytestsuitemake check-security— 54 passedmake check-errors— 303 passed