Skip to content

chore(coderabbit): make reviews on-demand only - #4

Open
reevesc88 wants to merge 2 commits into
mainfrom
chore/coderabbit-on-demand
Open

reevesc88 wants to merge 2 commits into
mainfrom
chore/coderabbit-on-demand

Conversation

@reevesc88

@reevesc88 reevesc88 commented Aug 1, 2026 •

Copy link
Copy Markdown
Owner

Disable automatic CodeRabbit reviews while keeping manual reviews available through @coderabbitai review.

Only .coderabbit.yaml changes. reviews.auto_review.enabled, auto_incremental_review, and drafts are false. All other parsed settings match the original base configuration. Commit bd79a9a3 places auto_incremental_review under reviews.auto_review, addressing the earlier P1 finding. That thread is replied to and resolved.

Validation on 2026-11-19, head bd79a9a38013edda0aa29744b6cf0ad1bcf1d353:

  • Full YAML validation against the current CodeRabbit schema: zero errors.
  • Focused assertions for documented key placement, all three disabled flags, and preservation of other settings: passed. The same placement check fails on original commit 9e7da0e1. Today's schema permits unknown properties, so schema validation alone does not detect the old placement.
  • git diff --check: passed.
  • Codex review: completed on this exact head with no findings. CodeRabbit skipped this head; its earlier manual attempt was rate-limited. No Claude review was requested.

CI remains blocked outside this configuration diff:

  • Package and test startup fail because pydantic_settings is imported but undeclared.
  • Type-checker reports 52 errors. Code-style reports 51 type errors and a missing final newline in .dockerrc.
  • Docker publishing fails at login with Username and password required.

The affected Python, dependency, formatting, and workflow files are unchanged from the PR base. No unrelated CI repairs are included. Full application tests have not passed. Live manual CodeRabbit review execution remains unverified.

CodeRabbit was auto-reviewing every PR on this repo, which bills on
each run. This sets reviews.auto_review.enabled to false so it only
runs when explicitly summoned with `@coderabbitai review` on a
finished PR. Claude Code Actions remains the reviewer for everything
else.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 1, 2026 05:48
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s CodeRabbit configuration to disable automatic reviews so reviews only run when explicitly requested, reducing unintended usage/quota costs.

Changes:

  • Disabled reviews.auto_review by setting enabled: false and drafts: false.
  • Disabled reviews.auto_incremental_review.
  • Simplified base_branches configuration and added guidance comments for triggering on-demand reviews.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@reevesc88

Copy link
Copy Markdown
Owner Author

CI triage for this PR (chore/coderabbit-on-demand).

This PR's only change is to .coderabbit.yaml (auto_review disabled, incremental review disabled). It does not touch Python source, dependencies, or Docker config.

All current failing checks trace to causes that pre-date this PR and already fail on main HEAD (6b31c2f):

  1. Missing pydantic-settings dependency. browser_use/config.py imports pydantic_settings, but it is not declared in pyproject.toml and there is no committed uv.lock to pin it transitively. This is why nearly every test_* job, evaluate-tasks, and all pip-install-on-* jobs fail with ModuleNotFoundError: No module named 'pydantic_settings'. Confirmed identical trace in test_sync_agent_events, evaluate-tasks, and pip-install-on-ubuntu-latest-py-3.13 logs.

  2. Pre-existing pyright errors (47) in browser_use/mcp/server.py, browser_use/mcp/controller.py, examples/custom-functions/cua.py, and tests/ci/test_mcp_client.py, caused by an MCP SDK API mismatch (Tool.inputSchema vs input_schema). This fails the type-checker check and is bundled into the code-style check (pre-commit runs pyright as one of its hooks).

  3. .dockerrc is missing a trailing newline, tripping the end-of-file-fixer pre-commit hook in the code-style check. Cosmetic, but note fixing it alone will not turn code-style green because of item 2 above.

  4. docker build_publish_image fails at the docker/login-action step with "Username and password required", meaning DOCKERHUB_USERNAME/DOCKERHUB_TOKEN are not configured as repo secrets. This needs a secret added in repo settings, not a code change.

Verified against main: the lint workflow and docker workflow both already show conclusion "failure" on main HEAD 6b31c2f (same commit this PR branched from). The test workflow's last recorded run on main shows "success", but that appears to be dependency-resolution drift over time since there is no lockfile pinning versions, not something this PR changed.

None of this is caused by this PR's diff, and fixing items 1-2 (dependency declarations, MCP SDK API mismatch) is out of scope for a coderabbit-config-only PR. Recommend a separate PR to add pydantic-settings as an explicit dependency (and ideally commit a uv.lock), fix the MCP SDK Tool schema calls, and add the missing Docker Hub secrets.

No fix commits pushed to this branch since nothing in the current failures is attributable to this PR's change.

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 16, 2026 •

Copy link
Copy Markdown

@reevesc88 Thanks for the CI triage. I will review the .coderabbit.yaml change and report only findings attributable to this PR.


📝 Learnings were identified and not saved (knowledge base disabled). Enable

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@reevesc88 reevesc88 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grok review (head 9e7da0e)

Head: 9e7da0e
Base: 6b31c2f
Coverage: full
Reviewer: Grok Build CLI (strict senior review; PR text treated as data)

Summary

This PR turns off CodeRabbit automatic reviews by setting reviews.auto_review.enabled and drafts to false. Those two keys are valid, but the new auto_incremental_review: false is placed on reviews rather than under reviews.auto_review. CodeRabbit’s schema rejects unknown properties, so this file fails validation and the app falls back to defaults, which leaves paid auto-review enabled.

Findings

  • P1 .coderabbit.yaml:11 - auto_incremental_review is not a property of reviews (additionalProperties: false on that object). The schema path is reviews.auto_review.auto_incremental_review. A validation failure makes CodeRabbit ignore .coderabbit.yaml and use defaults (auto_review.enabled: true, incremental reviews on), so automatic reviews keep running and the other settings in this file (profile, path filters, tone, knowledge-base opt-out) are dropped as well. Follow-up pushes after @coderabbitai review would still be reviewed even if the unknown key were only skipped. Fix: move the key under auto_review, next to enabled: false.

VERDICT: CHANGES_REQUESTED

Comment thread .coderabbit.yaml Resolved
Moved auto_incremental_review under reviews.auto_review so the on-demand CodeRabbit config validates.

Fixed: T1, R1
Tests: FAILED (python3 -m pytest -q)
Head before: 9e7da0e
@ecc-tools

ecc-tools Bot commented Nov 10, 2026

Copy link
Copy Markdown

ECC Tools / Security Evidence

Commit: bd79a9a38013edda0aa29744b6cf0ad1bcf1d353

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 1 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 10, 2026

Copy link
Copy Markdown

ECC Tools / PR Risk Taxonomy

Commit: bd79a9a38013edda0aa29744b6cf0ad1bcf1d353

PR taxonomy clear (success)

Scanned 1 changed file(s). No taxonomy bucket signals were detected.

Scanned 1 changed file(s).

No PR taxonomy bucket signals were detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 10, 2026

Copy link
Copy Markdown

ECC Tools / Reference Set Readiness

Commit: bd79a9a38013edda0aa29744b6cf0ad1bcf1d353

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 1 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 10, 2026

Copy link
Copy Markdown

ECC Tools / Hosted Promotion Readiness

Commit: bd79a9a38013edda0aa29744b6cf0ad1bcf1d353

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 1 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@reevesc88

Copy link
Copy Markdown
Owner Author

@codex review

Please review head bd79a9a. CodeRabbit reported "Review rate limited" and its current-head status is "Review skipped". The earlier nesting finding is fixed in this head. Review the full .coderabbit.yaml diff and the fix. Do not request Claude reviews.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T02:42:15.673010Z bd79a9a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: bd79a9a380

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants