Skip to content

[WIP] add keycloak auth provider - #5797

Closed
valerius21 wants to merge 1 commit into
redwoodjs:mainfrom
valerius21:topic/auth
Closed

valerius21 wants to merge 1 commit into
redwoodjs:mainfrom
valerius21:topic/auth

Conversation

@valerius21

Copy link
Copy Markdown

No description provided.

@netlify

netlify Bot commented Jun 21, 2022 •

Copy link
Copy Markdown

✅ Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit a040211
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62b20ba2bc2c6b00089a2aa5

@valerius21 valerius21 changed the title add keycloak auth provider [WIP] add keycloak auth provider Jun 21, 2022
@valerius21
valerius21 marked this pull request as draft June 21, 2022 18:20
@jtoar

jtoar commented Jul 5, 2022 •

Copy link
Copy Markdown
Contributor

Hey @valerius21, thanks for your patience! My reply here will be similar to this one: #5745 (comment). We just discussed this PR and a few others that add auth providers today. Redwood already has quite a few auth providers, and as we add more, the cost of maintaining them all is in the back of our minds. A post-v1 goal of ours was to decouple auth. We haven’t made headway on it yet, but we’re going to prioritize figuring out what "decoupling auth" would mean this week. I.e. exactly how much work is it, and once we know that, when could we get it done?

If it turns out that decoupling auth is months of work, we'll punt on it. But if we think we can do it soon, we’re going to ask you to wait till we’ve got that figured out. But we're timeboxing ourselves a bit: we'll let you know by ~next week. Till then you're welcome to continue working on this one, or you can wait till you hear back from us. Thanks for taking the time to contribute!

@matbgn

matbgn commented Jul 5, 2022

Copy link
Copy Markdown

Let me also emphasis that Keycloak (https://en.m.wikipedia.org/wiki/Keycloak#History) is by far the most advanced open source IAM solution, so I think it will be a nice investment for Redwood to dig in it.

As an enterprise we were right on the path of searching a way to couple it with RW before landing on this issue today :-D

@valerius21

valerius21 commented Jul 8, 2022 •

Copy link
Copy Markdown
Author

@jtoar

Thank you very much for letting me know! I'll keep an eye on everything and I'm excited to hear back from you.

@jtoar

jtoar commented Jul 16, 2022

Copy link
Copy Markdown
Contributor

Hey @valerius21, thanks for your patience! We’ve done the preliminary work around decoupling auth. The team feels good about it, so we’re going to move ahead with that. But instead of asking you to just wait for us to finish, we’d like to invite you to collaborate with us on this. No pressure—totally optional! And while we’re still working out all the details, we think that this would mean the following:

  • You’ll be given access to a new redwoodjs GitHub repo to develop against (in this case, something like redwoodjs/keycloak). This would eventually be a package published to npm
  • You’ll basically do what you did in this PR, but in that repo against a new auth API. You’ll collaborate with us by using and giving us feedback about the new auth API because we want to make sure it’s easy to use

I'm sure you still have questions, but are you open to trying something like that out? Let us know and we'll circle back when we have it all ironed out.

@Tobbe

Tobbe commented Dec 17, 2023

Copy link
Copy Markdown
Contributor

I'm cleaning up our PRs in preparation for the next major version of RW. This one seems to have gone stale, so I'm going to close it.
I really appreciate the work that's gone into this PR 🌟

If anyone is still interested in working on this feature or if there are any unresolved issues, please feel free to:

  1. Reopen this PR: If there are specific changes or updates needed.
  2. Create a new PR: In case you'd like to start fresh or make significant modifications.

Let's keep the collaboration going 🚂 If you have any questions or need assistance, don't hesitate to reach out. Thanks again for the contributions 🙏

@Tobbe Tobbe closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants