Skip to content

fix: ensure that connect_devices is called#46

Merged
jacopoabramo merged 1 commit into
mainfrom
fix/connect-startup
Apr 16, 2026
Merged

fix: ensure that connect_devices is called#46
jacopoabramo merged 1 commit into
mainfrom
fix/connect-startup

Conversation

@jacopoabramo
Copy link
Copy Markdown
Collaborator

ophyd-async requires a call to device.connect() to ensure the signal backends are properly connected.

Right now this is just a patch to ensure that for prototyping this works, but I'm evaluating if this is something that should be delegated to the presenter layer.

The reason is that I originally intended to support methods such as standby(), connect(), disconnect() in order to manage the device connection to the application so that the user may decide to keep the application alive but disconnect the device or put it in a standby mode if available.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/redsun/containers/container.py 50.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/redsun/containers/container.py 81.73% <50.00%> (-0.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacopoabramo jacopoabramo merged commit bca8e88 into main Apr 16, 2026
19 of 20 checks passed
@jacopoabramo jacopoabramo deleted the fix/connect-startup branch April 16, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant