various windows build fixes/improvements#23
Merged
redstrate merged 1 commit intoredstrate:mainfrom Jan 31, 2026
Merged
Conversation
- switch Configure helper function to use a list of args instead of a single string, so that paths with spaces won't break it (?probably at least, I didn't actually have any spaces in the paths of mine so it didn't actually matter in the end) - move `breeze-icons` build to above `kiconthemes`, since build for the latter will fail if the former isn't there yet - skip re-downloading zips if they've already been downloaded (same as how cloning of git repos was already handled) - added one stray include that was missing - change copied dll name from zlibd.dll to zd.dll - add copying of qsqlited.dll which is required for DataExplorer
Owner
|
Thanks for updating the script, I appreciate it!
Opened a follow-up issue in #24, those are stuff fixable by me and can be done later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
worked on getting this building on windows for me to investigate the issue w/ data explorer not launching, made a few improvements to the windows build scripts too while i was in there.
changes:
breeze-iconsbuild to abovekiconthemes, since build for the latter was failing from the former not being there yeta couple other notes from stuff i ran into, but which aren't changed in this PR: