Step2 lucas forked#37
Open
Sleli42 wants to merge 21 commits into
Open
Conversation
eric-basley
reviewed
Jan 17, 2017
|
|
||
| export const addTodo = name => ({ | ||
| type: ADD_TODO, | ||
| todo2add: { id: (todoId += 1), name, tasks: {} }, |
Contributor
There was a problem hiding this comment.
rename todo2add as payload or todo
eric-basley
reviewed
Jan 17, 2017
| id: IDtodo, | ||
| }); | ||
|
|
||
| export const addTask = (name, IDtodo) => ({ |
Contributor
There was a problem hiding this comment.
c'est quoi cette syntaxe : la convention de non n'est pas respectée renomer IDtodo en id
eric-basley
reviewed
Jan 17, 2017
| @@ -0,0 +1,74 @@ | |||
| let todoId = 2; | |||
eric-basley
requested changes
Jan 17, 2017
Contributor
eric-basley
left a comment
eric-basley
left a comment
There was a problem hiding this comment.
close to release code, review var names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.