Skip to content

aws_dynamodb_batcher: extract hasUnpersistedFrontier for readability and reuse #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Leward wants to merge 1 commit into from
Open

aws_dynamodb_batcher: extract hasUnpersistedFrontier for readability and reuse #4748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions internal/impl/aws/dynamodb/batcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,12 @@ func (st *shardAckTracker) advanceFrontier(frontier string) {
}
}

// hasUnpersistedFrontier reports whether the shard has a contiguous acked
// sequence frontier that has not yet been persisted.
func (st *shardAckTracker) hasUnpersistedFrontier() bool {
return st.frontier != "" && st.frontier != st.persisted
}

// AckBatch marks a tracked batch as acknowledged, advances the shard's
// contiguous frontier, and persists a checkpoint once enough messages have
// been acked since the last persisted position. Settlement goes through the
Expand Down Expand Up @@ -475,7 +481,7 @@ func (b *RecordBatcher) maybePersist(ctx context.Context, cp checkpointer, st *s

for {
b.mu.Lock()
due := st.pending >= cp.CheckpointLimit() && st.frontier != "" && st.frontier != st.persisted
due := st.pending >= cp.CheckpointLimit() && st.hasUnpersistedFrontier()
persistSeq := st.frontier
persistTime := st.frontierTime
pendingAtCompute := st.pending
Expand Down Expand Up @@ -522,7 +528,7 @@ func (b *RecordBatcher) PendingCheckpoints() map[string]CheckpointValue {

checkpoints := make(map[string]CheckpointValue, len(b.shards))
for shardID, st := range b.shards {
if st.frontier != "" && st.frontier != st.persisted {
if st.hasUnpersistedFrontier() {
checkpoints[shardID] = CheckpointValue{
SequenceNumber: st.frontier,
ApproxCreationTime: st.frontierTime,
Expand Down Expand Up @@ -631,7 +637,7 @@ func (b *RecordBatcher) LastCheckpointsCount() int {
defer b.mu.Unlock()
n := 0
for _, st := range b.shards {
if st.frontier != "" && st.frontier != st.persisted {
if st.hasUnpersistedFrontier() {
n++
}
}
Expand Down