aws_dynamodb_cdc: extract per shard in-flight message counting logic - #4746
Open
Leward wants to merge 1 commit into
Open
aws_dynamodb_cdc: extract per shard in-flight message counting logic#4746Leward wants to merge 1 commit into
Leward wants to merge 1 commit into
Conversation
|
|
Leward
force-pushed
the
dynamo_batcher_impr_2
branch
from
August 31, 2026 18:30
c68b332 to
44a5333
Compare
Extracted new functions (`shardInFlightLocked` and `ShardInFlightCount`) to make the main `TryReserve` logic easier to reason about. This also allows us to more easily unit test this counting logic in isolation.
Leward
force-pushed
the
dynamo_batcher_impr_2
branch
from
August 31, 2026 19:01
44a5333 to
9b42e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted new functions (
shardInFlightLockedandShardInFlightCount) to make the mainTryReservelogic easier to reason about.This also allows us to more easily unit test this counting logic in isolation.