aws_dynamodb_cdc: simplify the counting of in-flight messages - #4744
Open
Leward wants to merge 4 commits into
Open
aws_dynamodb_cdc: simplify the counting of in-flight messages#4744Leward wants to merge 4 commits into
Leward wants to merge 4 commits into
Conversation
This makes it easier for a human to reason about the code. It is functionally identical. The code comment has been reworder to be easier to read and understand.
|
|
|
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Improves readability by providing a more descriptive variable name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier for a human to reason about the code. It is functionally identical.
The code comment has been reworded to be easier to read and understand.
The
InFlightCount()makes it easier to create unit tests focus on that specific logic (seeTestBatcherInFlightCount).