-
Notifications
You must be signed in to change notification settings - Fork 960
prometheus: purge deleted stream metric series in streams mode (CON-555) #4742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
squiidz
wants to merge
2
commits into
main
Choose a base branch
from
con-555-purge-deleted-stream-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeletePartialMatchis applied unconditionally to every registered vec, including vecs that do not declare the label being matched on.In
prometheus/client_golang(pinned here atv1.23.2per go.mod#L136),MetricVec.DeletePartialMatch→metricMap.deleteByLabels→matchPartialLabels, which looks each requested label key up in the vec's variable label names and skips the comparison entirely when the key is not one of them. If none of the requested keys are variable labels of that vec, the match is vacuously true and every series in the vec is deleted.Failure scenario:
DeleteSeriesPartialMatch({"stream": "foo"})is called while a metric vec exists that has nostreamlabel — e.g. the zero-labeluptimecounter created at metrics_prometheus_test.go#L189-L191, or any global/non-stream-scoped vec. All of its series are dropped from/metrics, so deleting one stream silently wipes unrelated counters and gauges. Note this also means the new test's ownassert.Contains(t, body, "\nuptime 9")assertion at line 208 should be failing — worth confirming the test actually passes locally before merging.Suggested fix: record the declared label names on
promCounterVec/promGaugeVec/promTimingVec/promTimingHistVec(they already carrycount) and skip any vec that does not declare every key present inlabelsbefore callingDeletePartialMatch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked against the pinned client_golang (v1.23.2): the premise is inverted. In
matchPartialLabels(prometheus/vec.go:468-483), when a requested key is not one of the vec's variable labels,indexOfreturnsvalidLabel == false, the inner branch is skipped, and the function hitsreturn false— an unknown label key is a non-match for that vec, not a wildcard. There is no vacuously-true path; the loop onlycontinues on an actual value match.Consistent with that,
TestPrometheusDeleteSeriesPartialMatchpasses as written, including theuptime 9assertion this comment predicted would fail. Added a labeled vec without thestreamlabel (batch_created{mechanism="count"}) to the test to pin the non-match behavior explicitly.