CDC backoff cancel - #4735
Open
squiidz wants to merge 2 commits into
Open
Conversation
Review follow-on: ReadChanges backed off with plain time.Sleep, so a soft stop - Close's graceful path or the poisoned-publisher teardown in ReadBatch - had to wait out whatever mining or backoff interval was in flight before the session could report stopped. Both intervals are user-configurable and can be long, which undercut the teardown's bounded-wait contract. The sleeps now select on the session context and return its error, so cancellation cuts them short immediately.
Same exposure as the oracledb mining backoff: ReadChangeTables backed off with plain time.Sleep, so a soft stop - Close's graceful path or the poisoned-publisher teardown in ReadBatch - had to wait out the user-configurable backoff interval before the session could report stopped. The sleep now selects on the stream context and returns its error, so cancellation cuts it short immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.