enforce releases / ship-files are in sync - #535
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 553f4fd07b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
CI-only guard on the release workflow; no product runtime or packaging logic changes beyond blocking bad release state.
Overview
Adds a release gate in the NuGet publish workflow so a release cannot proceed unless public API tracking files are in the expected “shipped” state.
Before version bump, pack, and publish, a new Verify public API is shipped step scans every
PublicAPI.Unshipped.txtin the repo. If any file still has real API entries (anything that isn’t a blank line or#comment), the job fails with a GitHub Actions error pointing at that file and listing the leftover lines, telling maintainers to promote entries toPublicAPI.Shipped.txtfirst.Reviewed by Cursor Bugbot for commit bb73967. Bugbot is set up for automated code reviews on this repo. Configure here.