-
Notifications
You must be signed in to change notification settings - Fork 60
Migrate solution to slnx format #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "dotnet-test-explorer.testArguments": "/p:CollectCoverage=true /p:CoverletOutputFormat=lcov /p:CoverletOutput=./lcov.info", | ||
| "dotnet-test-explorer.testProjectPath": "**/*NRedisStack.Tests.csproj", | ||
| "dotnet.defaultSolution": "NRedisStack.sln", | ||
| "dotnet.defaultSolution": "NRedisStack.slnx", | ||
| "dotnet.unitTests.runSettingsPath": ".vscode/.runsettings" | ||
| } |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <Solution> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When this repo is built through the existing Useful? React with 👍 / 👎. |
||
| <Folder Name="/Build/"> | ||
| <File Path=".github/actions/run-tests/action.yml" /> | ||
| <File Path=".github/workflows/integration.yml" /> | ||
| <File Path="Directory.Build.props" /> | ||
| <File Path="Directory.Packages.props" /> | ||
| <File Path="global.json" /> | ||
| <File Path="version.json" /> | ||
| <Project Path=".github/ci.csproj" /> | ||
| <Project Path="tests/dockers/dockers.csproj" /> | ||
| </Folder> | ||
| <Project Path="docs/docs.csproj" /> | ||
| <Project Path="src/NRedisStack/NRedisStack.csproj" /> | ||
| <Project Path="tests/Doc/Doc.csproj" /> | ||
| <Project Path="tests/NRedisStack.Tests/NRedisStack.Tests.csproj" /> | ||
| </Solution> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the action uses the new default
build-sdk-version: 10.0(or any caller passes a channel-style value thatsetup-dotnetaccepts), this writes that value directly assdk.versioninglobal.json. The .NET global.json schema requires the full SDK version and explicitly does not support values like10or10.0(https://learn.microsoft.com/en-us/dotnet/core/tools/global-json#version), so the pin added for.slnxdiscovery is invalid and subsequentdotnet restore/build/packcan fall back to whatever SDK the runner happens to have installed instead of the intended build SDK. Use a full feature-band version or the resolvedsetup-dotnetoutput here.Useful? React with 👍 / 👎.