stop dependabot trying to update GHATL - #531
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context #476, #479, #530
There is a hard dependency conflict here
What actually breaks (two layers):
error CS1705: 'GitHubActionsTestLogger' 3.0.5 uses 'Microsoft.Testing.Platform 2.0.0'
which has a higher version than referenced assembly 'Microsoft.Testing.Platform 1.9.1'
Why 1.9.1 is pinned: our xunit.v3 3.2.2 (current stable) drags in the xunit.v3.core.mtp-v1 / xunit.v3.mtp-v1 packages, which pin Microsoft.Testing.Platform to 1.9.1. GHATL 3.x is built against MTP 2.0. Those can't coexist. So the update genuinely cannot work today — it's blocked upstream on xunit, not on anything we're doing wrong.
When it will be possible: xunit is mid-migration from MTP v1 → v2. The mtp-v2 variant only exists in xunit.v3 4.0.0-pre.* (confirmed 4.0.0-pre.154 installs xunit.v3.mtp-v2). There is no stable xunit.v3 on MTP 2.0 yet, and Microsoft.NET.Test.Sdk latest stable is still 18.8.1 (what we have). So GHATL 3.x becomes viable only once we move to xunit.v3 4.x (MTP 2.0), which is still prerelease.
Note
Low Risk
CI/dependency-bot configuration only; no runtime or test code changes.
Overview
Adds a Dependabot ignore for
GitHubActionsTestLoggerversions ≥ 3.0.0, so daily NuGet update PRs stop proposing upgrades that cannot build today.The inline comment documents why: GHATL 3.x targets Microsoft.Testing.Platform 2.0, while the repo stays on xunit.v3 3.x and MTP 1.9.1 (via
Directory.Packages.propsat 2.4.1). Revisit when moving to xunit.v3 4.x / MTP v2.Reviewed by Cursor Bugbot for commit 51d34db. Bugbot is set up for automated code reviews on this repo. Configure here.