Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
5ab3f12
test: mapdatasectioncheck — data Sections must not crowd code out of …
joyful-ii-V-I Oct 1, 2026
37bf96f
fix(edit-check): a C/C++ declaration and its definition are one contract
joyful-ii-V-I Oct 1, 2026
76b54af
fix(edit-check): every handle the ambiguity refusal prints round-trips
joyful-ii-V-I Oct 1, 2026
e04a2e8
feat(resolve): accept Class.method and Class#method as selectors
joyful-ii-V-I Oct 1, 2026
417ba41
feat(map): rankDefaultMap — data Sections never crowd code out of the…
joyful-ii-V-I Oct 1, 2026
1307b9b
test(printf-parity): re-pin help_all for the Scope.name|Scope#name he…
joyful-ii-V-I Oct 1, 2026
aa09642
fix(whereis): answer for the checkout, not only HEAD's commit
joyful-ii-V-I Oct 1, 2026
4b3ace8
feat(map): code-first row pick (Option B) — A failed its registered -…
joyful-ii-V-I Oct 1, 2026
67fa7d1
refactor(whereis): the row order and the overlay checks get names
joyful-ii-V-I Oct 1, 2026
06b7e2d
refactor(whereis): inline the two one-line overlay checks; the sort k…
joyful-ii-V-I Oct 1, 2026
0a645bb
docs: map data Sections — the registered result (A failed §3(a), B sh…
joyful-ii-V-I Oct 1, 2026
7d1e3e6
refactor(serialize): dataSectionsNext spells the registered next= by …
joyful-ii-V-I Oct 1, 2026
ff6db83
fix(whereis): the worktree listing reads through gitCommandLines
joyful-ii-V-I Oct 1, 2026
af7256c
test(printf-parity): re-pin help_all for the --whereis worktree help …
joyful-ii-V-I Oct 1, 2026
3bc1c0d
refactor(serialize): codeFirstKeep assembles the pick with a stable p…
joyful-ii-V-I Oct 1, 2026
3df6350
docs(limits): count the edit-check signature-read cap
joyful-ii-V-I Oct 1, 2026
d7d21e3
fix(whereis): a Class.method selector is not answered with a measured…
joyful-ii-V-I Oct 1, 2026
1f14f21
test: full-suite fixups — clean-env in mapdatasectioncheck, --help re…
joyful-ii-V-I Oct 1, 2026
2fa3f09
Merge origin/main (953818d6) into lane/map-data-sections-067; review …
joyful-ii-V-I Oct 1, 2026
d31e61e
fix(edit-check): review round — full scope chain, no declaration hand…
joyful-ii-V-I Oct 1, 2026
fa3317d
fix(whereis): suite follow-ups for the worktree overlay
joyful-ii-V-I Oct 1, 2026
4f1d96f
fix: a not-found refusal also answers on stdout; whereis demotes test…
joyful-ii-V-I Oct 1, 2026
09b77cc
refactor(whereis, uses): keep the touched functions within their qual…
joyful-ii-V-I Oct 1, 2026
4130b0a
fix(edit-check): a macro-opened namespace makes the scope chain unrea…
joyful-ii-V-I Oct 1, 2026
d134da1
refactor(rename-probe): candidates and the HEAD-copy probe are two fu…
joyful-ii-V-I Oct 1, 2026
4611889
docs(limits): register kMaxRenameProbeFiles (232 caps)
joyful-ii-V-I Oct 1, 2026
9333eef
test(usesselector): the wrong-scope control reads the found="0" answe…
joyful-ii-V-I Oct 1, 2026
6862db7
fix: suite follow-ups for the not-found answers
joyful-ii-V-I Oct 1, 2026
dd34930
test(static-scan): shard the --match scans so crashsweepcheck and haz…
joyful-ii-V-I Oct 2, 2026
e74e0b5
fix(whereis, not-found): review round rv-fresh-067 (M1-M8, S1-S3)
joyful-ii-V-I Oct 2, 2026
eb7ab91
Merge lane/map-data-sections-067 @ 2fa3f09f into integration/train-23
joyful-ii-V-I Oct 2, 2026
5a2aba3
Merge lane/editcheck-067 @ dd349309 into integration/train-23
joyful-ii-V-I Oct 2, 2026
26c555f
chore(coderabbit): turn off the docstring-coverage pre-merge check
joyful-ii-V-I Oct 2, 2026
2ce8926
train 23: kParserVer 129 -> 132 (cache-key hygiene); re-pin qschemetrip
joyful-ii-V-I Oct 2, 2026
28d4bd1
train 23: derived figures from the merged binary; CHANGELOG sorted
joyful-ii-V-I Oct 2, 2026
d9baac9
Merge lane/fresh-067 @ e74e0b5a into integration/train-23
joyful-ii-V-I Oct 2, 2026
3bb49ca
train 23: derived figures re-derived once after the last merge
joyful-ii-V-I Oct 2, 2026
01923bf
train 23: CodeRabbit harvest on 3bb49ca4 — edit-check pairing gaps, t…
joyful-ii-V-I Oct 2, 2026
365c25c
train 23: edit-check source read keeps its whole-read flag beside the…
joyful-ii-V-I Oct 2, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .coderabbit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# - No re-review on every push: each fix commit used to start a new pass over a new diff.
# - No automatic reply inside review threads: every in-thread answer used to wake another pass.
# - Vendored parsers and generated/pinned files are excluded; a review of them cannot change them.
# - No docstring-coverage pre-merge check: the house style documents contracts where they bite, not every symbol.
# CodeRabbit reads this file from the PR's head branch, so a fork PR picks it up once it merges main.
reviews:
profile: chill # the default; "quiet" is the lever if noise persists
Expand All @@ -31,5 +32,8 @@ reviews:
labelled a floor; a zero means none found. Flag silent zeros, undisclosed truncation, and gate arms
that cannot fail.
sequence_diagrams: false
pre_merge_checks:
docstrings:
mode: "off" # quoted: a bare off is a YAML 1.1 boolean, and the schema wants the string
chat:
auto_reply: false # thread replies no longer wake it
2 changes: 2 additions & 0 deletions .github/pargates-shard-weights.json
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@
"duprowcheck.sh": 1.5,
"dynmapsimdcheck.sh": 36.4,
"editcheckcheck.sh": 17.8,
"editcheckdeclcheck.sh": 46.2,
"editchecknotecheck.sh": 5.1,
"edithandlehintcheck.sh": 3.0,
"editpayloadbinarycheck.sh": 2.0,
Expand Down Expand Up @@ -285,6 +286,7 @@
"luacheck.sh": 3.5,
"macroedgecheck.sh": 3.6,
"manifestcheck.sh": 62.9,
"mapdatasectioncheck.sh": 55.0,
"mapdiffcheck.sh": 3.3,
"matchcapturecheck.sh": 11.8,
"matchgrammarcheck.sh": 0.6,
Expand Down
1 change: 1 addition & 0 deletions .ripwire_quality_acks
Original file line number Diff line number Diff line change
Expand Up @@ -1456,6 +1456,7 @@ ack short-horizon-churn e8abfc6e8faace3b 5 cid=ba58d27ecdba1f2f OPTREMARKS F3 (d
ack short-horizon-churn e98afe9f7356dca7 116 cid=9ff08b0551bdf16e macro-vocabulary rename (VERIFY/DEGRADED_PATH_ALERT family -> ASSUME/EXPECTS/ENSURES/DASSERT/UNREACHABLE/VALIDATE/DISCLOSE): identifier-only churn across 179 files, no logic change (rename_selfcheck.py, --check idempotent; ripwire --no-cache byte-identical old binary vs new binary on 3 trees)
ack short-horizon-churn e9db97026e7265d2 145 cid=5e8fa13c43d29808 macro-vocabulary rename (VERIFY/DEGRADED_PATH_ALERT family -> ASSUME/EXPECTS/ENSURES/DASSERT/UNREACHABLE/VALIDATE/DISCLOSE): identifier-only churn across 179 files, no logic change (rename_selfcheck.py, --check idempotent; ripwire --no-cache byte-identical old binary vs new binary on 3 trees)
ack short-horizon-churn ea9e556ae2c5b78f 3 cid=8f4414705d24d6f7 by=src/* member-variable round (card A3), side-table rule: symbols this round created (collectFieldUseSites, FieldUseAnswer, memberOwnerRefusal, declaredFieldSet, isInstanceFieldSite, dropFieldDefinitionSites, fieldCaptureKept) and touched twice within it while fields moved from ing.symbols to the IngestResult::fields side table under the orchestrator's rule; collectFacts/buildDefSpanIndex each carry ONE deliberate edit | prior: member-variable round (card A3): kUsesLegendOpen gains the one-sentence pointer to the member form, buildDefSpanIndex zero-widths field spans so containment attribution is byte-identical, kParserVer 74->75 for the new SymKind::Field + member use-site capture — each a single deliberate edit on a symbol other rounds touched recently
ack short-horizon-churn eac088e77e30bd57 11 cid=4b0efd60def2f3b3 now=11 was=0 facet=self p=src/editcheck.h:281 review fix round (M2/M3): editCheckGroups is edited again on this branch to stop offering declaration-only handles and to verify only offered spellings; the churn is the review loop itself
ack short-horizon-churn ec2848a4801493a2 153 cid=e95af915562f1c12 every short-horizon-churn row in this delta names a symbol this lane wrote or rewrote under review (the two compact-legend tables, the four map legends, MapAnnotations, serialize/writeRecentRows, pagingDisclosure, the cli.h guards, scopedRecentPage, refuseInertMainModifiers). The kind measures 2+ committed in-window rewrites of the same lines, which is what a reviewed lane does to its own code: round 1 added the block, round 2 answered CodeRabbit, round 3 answered the Fable review (the paging half, the stub vocabulary, the derived preemption, the crawl check). The churn here is the review cycle, not an unstable design, and it decays out of the window on its own. | prior: L7 lint-catalog: short-horizon-churn=self is ambient repo-wide churn on cli.h/main.cpp/didyoumean.h (49-92 commits/14d, unrelated lanes) inherited by any edit to these hot, central dispatch symbols, not fixable by reshaping this change; runLint/printUsage complexity+verbosity residual is the minimum new dispatch glue (4 extracted helper calls + 3 new flags' --help text) after extracting emitLintCatalog/resolveLintSelection/computeLintApplicability/printLintRuleTallyRow out of runLint, which cut the original complexity delta from +121 to +16
ack short-horizon-churn ec9ec1cc3c01feb4 113 cid=691a45e7025a3510 round 3 test-script iteration: pymodulealiascheck.sh helper functions touched across three consecutive review-response rounds — expected churn from addressing review feedback quickly, not a structural defect
ack short-horizon-churn ed0cbdfe7fa72e8c 154 cid=f42bf8683228ffff C1 F-06/F-07/F-10 (the listing-paging round): three listing verbs learn to disclose and page their row listings, and every gating row is that one change. api-surface 14 = ONE trailing DEFAULTED parameter each (an int pageOffset, an McpPageArgs window, a SituPageArgs, or the next= invocation a header now carries) on the emitters that must be TOLD their window — writeFlags/writeGate, writeCappedRows/writeCappedList/writeFlip/writeFlipHeader/writeFlipLights, computeFlip, nearestGateNames (which gains its cap and its TOTAL, the disclosure itself), situShowingNote/writeSituation, and the three MCP twins flagsText/flipText/situationDiffJson; additive by construction, every pre-existing call site compiles unchanged, and the alternative — a second capped emitter per verb — is the drift this repo removes rather than adds, because two emitters that disagree about a window can drop the row that IS the answer. verbosity 3 = kDocDriftLegend +20 lines and writeDocDriftPage +10 are the in-band vocabulary a reader needs to read shown_failed=/failed_capped=/failed_total= where they meet it (the rationale and the next= scan were already hoisted OUT of the body into their own function and comment, which took the complexity row to zero and the LOC row from +48 to +10); dispatchMcpLine +12 is two pagedResult wrappers on a pre-existing 1376-line dispatcher this lane adds to rather than creates. complexity 1 = the same dispatcher, +9 on a base of 518. duplication 1 = flagsText | flipText at 110 tokens, down from 131 after the shared mcpRowCap fold; the residual is getIndex + compute + captureXml, the shape EVERY index-backed MCP twin in this file has, and merging two verbs that return different results behind one entry point would be worse code than the clone. short-horizon-churn 19 = this lane's own footprint across cli.h/docdrift.h/darkflags.h/flipimpact.h/situ.h/mcp*, plus cli.h symbols three other lanes touched the same day; none foreign, none thrash.
Expand Down
Loading
Loading