Skip to content

revert(ci): ignore prow.ci.openshift.org in markdown link check - #5418

Merged
jonkoops merged 4 commits into
redhat-developer:mainfrom
zdrapela:revert-5409-fix/markdown-link-check-prow
Sep 16, 2026
Merged

jonkoops merged 4 commits into
redhat-developer:mainfrom
zdrapela:revert-5409-fix/markdown-link-check-prow

Conversation

@zdrapela

@zdrapela zdrapela commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Reverts #5409

Ignore https://docs.google.com, as they are shared RH-wide and not accessible for the check.

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.69%. Comparing base (2261e8e) to head (87af06d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5418      +/-   ##
==========================================
- Coverage   63.68%   59.69%   -3.99%     
==========================================
  Files         121      109      -12     
  Lines        2288     2062     -226     
  Branches      527      501      -26     
==========================================
- Hits         1457     1231     -226     
  Misses        829      829              
  Partials        2        2              
Flag Coverage Δ
rhdh 59.69% <ø> (-3.99%) ⬇️
Components Coverage Δ
Backend plugins ∅ <ø> (∅)
Backend app 69.69% <ø> (ø)
Frontend app 58.82% <ø> (ø)
Plugin utils ∅ <ø> (∅)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2261e8e...87af06d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zdrapela zdrapela changed the title Revert "fix(ci): ignore prow.ci.openshift.org in markdown link check" revert(ci): ignore prow.ci.openshift.org in markdown link check Sep 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@zdrapela
zdrapela marked this pull request as ready for review September 16, 2026 08:07
@github-actions

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Restore Prow link validation and exempt private Google Doc

🐞 Bug fix ⚙️ Configuration changes 📝 Documentation 🕐 Less than 10 minutes

Grey Divider

AI Description

• Restores markdown validation for Prow URLs by removing the domain-wide exclusion.
• Exempts one private Google Doc that automated link checks cannot access.
• Clarifies Prow URL prompts and capitalization in end-to-end test documentation.
Diagram

graph TD
  A["Markdown docs"] --> B["Link checker"] --> C{"Ignored URL?"}
  C -->|"Exact private doc"| D["Skip validation"]
  C -->|"Prow URL"| E["HTTP validation"] --> F["Prow service"]
Loading
High-Level Assessment

The PR uses the appropriate narrow approach: restore validation for the full Prow domain while exempting only the inaccessible Google Doc. A domain-wide Prow exclusion would hide unrelated broken links, while inline suppressions would scatter link-check configuration through documentation.

Files changed (2) +3 / -3

Documentation (1) +1 / -1
CI.mdClarify Prow URL access instructions +1/-1

Clarify Prow URL access instructions

• Corrects grammar and capitalization in the OpenShift CI environment access instructions. The guidance now clearly states that users are prompted for the Prow URL supplied by the OpenShift agent.

docs/e2e-tests/CI.md

Other (1) +2 / -2
link-checker.config.jsonRestore Prow checks and exempt one private document +2/-2

Restore Prow checks and exempt one private document

• Removes the domain-wide exclusion for 'prow.ci.openshift.org', allowing Prow links to be validated again. Adds an anchored exception for one private Google Doc that the automated checker cannot access.

.github/workflows/link-checker.config.json

@sonarqubecloud

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@rhdh-qodo-merge

Copy link
Copy Markdown

Important

The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@openshift-ci openshift-ci Bot added the lgtm label Sep 16, 2026
@jonkoops
jonkoops merged commit 2c7474f into redhat-developer:main Sep 16, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants