Conversation
Backport of redhat-developer#5405 to release-1.10. redhat-developer#5365 bumped better-sqlite3 to v13 with prebuilds; remove the root node-gyp devDependency and dependenciesMeta, the e2e-tests postinstall Playwright hook, and --mode=skip-build in CI. Update docs to document the explicit playwright install step and drop node-gyp prerequisites. Ref: RHDHBUGS-3725 Signed-off-by: Jon Koops <jonkoops@gmail.com>
|
Contributor
|
The container image build workflow finished with status: |
The root keytar built:false override is still required on release-1.10: without it, yarn install in the offline hermetic build tries to compile keytar and fails on missing libsecret-1.
Contributor
Author
|
Closing: release-1.10 does not have enableScripts or cluster-free E2E, so #5405 does not fix a broken scenario here. The partial backport also regressed hermetic builds by removing keytar dependenciesMeta without an equivalent on main. |
|
Contributor
|
The container image build workflow finished with status: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5405 to
release-1.10.#5365 already bumped better-sqlite3 to v13 with prebuilds on this branch. This drops the leftover root
node-gypdevDependency anddependenciesMeta, removes the e2e-testspostinstallPlaywright hook (and--mode=skip-buildin the e2e lint workflow), and updates docs to match.release-1.10does not haveenableScripts: truein.yarnrc.ymlor the cluster-free harness frommain, so those parts of #5405 do not apply here.RHDHBUGS-3725