-
Notifications
You must be signed in to change notification settings - Fork 226
chore(scripts): add dual RHEL9/RHEL10 hub image support (RHIDP-14884) #5262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
polasudo
wants to merge
4
commits into
redhat-developer:main
Choose a base branch
from
polasudo:feature/RHIDP-14884
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0877a54
feat(hub): migrate hub container build to UBI10/RHEL10 (RHIDP-14879)
polasudo 9e83616
chore(scripts): add dual RHEL9/RHEL10 hub image support (RHIDP-14884)
polasudo 79cdf98
fix(docs): format e2e-tests README for oxfmt (RHIDP-14884)
polasudo 292d427
Merge branch 'main' into feature/RHIDP-14884
nickboldt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -102,6 +102,17 @@ common::get_previous_release_version() { | |||||
| echo "${major_version}.${previous_minor}" | ||||||
| } | ||||||
|
|
||||||
| # Default downstream hub image repository for the current release branch. | ||||||
| # Maintenance branches (release-1.x) use RHEL 9 images; main / 2.y streams use RHEL 10. | ||||||
| common::default_hub_image_repo() { | ||||||
| local branch="${RELEASE_BRANCH_NAME:-main}" | ||||||
| if [[ "$branch" == release-* ]]; then | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| echo "rhdh/rhdh-hub-rhel9" | ||||||
| else | ||||||
| echo "rhdh/rhdh-hub-rhel10" | ||||||
| fi | ||||||
| } | ||||||
|
|
||||||
| # Generic polling helper - waits for a condition to become true | ||||||
| # Args: condition_cmd, max_attempts, wait_interval, description | ||||||
| # Returns: 0 on success, 1 on timeout | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -125,7 +125,8 @@ Follow the interactive prompts to select: | |||||
| 1. **Run mode**: Deploy only (default, for headed debugging) or Deploy and run tests | ||||||
| 2. **Job type**: OCP Helm PR tests, Nightly tests, Operator tests, etc. | ||||||
| 3. **Image type**: | ||||||
| - **Downstream** (`quay.io/rhdh/rhdh-hub-rhel9`): `next`, `latest`, or release-specific tag | ||||||
| - **Downstream RHEL 9** (`quay.io/rhdh/rhdh-hub-rhel9`): `next`, `latest`, or release-specific tag (maintenance branches) | ||||||
| - **Downstream RHEL 10** (`quay.io/rhdh/rhdh-hub-rhel10`): `next`, `latest`, or release-specific tag (`main` / 2.y stream) | ||||||
| - **PR image** (`quay.io/rhdh-community/rhdh`): Enter PR number | ||||||
|
|
||||||
| After the container finishes, you're back on your host with the cluster still accessible. | ||||||
|
|
@@ -139,6 +140,9 @@ For automation or quick runs, use CLI flags to skip interactive prompts: | |||||
| ./local-run.sh --pr 4023 --skip-tests | ||||||
|
|
||||||
| # Deploy downstream next image | ||||||
| ./local-run.sh --repo rhdh/rhdh-hub-rhel10 --tag next --skip-tests | ||||||
|
|
||||||
| # RHEL 9 maintenance stream image | ||||||
| ./local-run.sh --repo rhdh/rhdh-hub-rhel9 --tag next --skip-tests | ||||||
|
|
||||||
| # Use a custom registry | ||||||
|
|
@@ -158,15 +162,15 @@ Disconnected Operator and Helm nightlies can be started only via `local-run.sh` | |||||
|
|
||||||
| `local-run.sh` sets `DISCONNECTED=true` and `LOCAL_DISCONNECTED=1` for `*disconnected*` jobs. The e2e-runner bootstraps `MIRROR_*` **inside the container** under `${SHARED_DIR}/disconnected-mirror/` (worktree mount), using the cluster image registry route. Operator prepare uses `--to-registry OCP_INTERNAL`; Helm oc-mirrors to the exposed registry route. For air-gap prepare semantics, see [rhdh-operator](https://github.com/redhat-developer/rhdh-operator) docs — this path does not duplicate them. | ||||||
|
|
||||||
| | Flag | Description | | ||||||
| | ------------------ | -------------------------------------------------------------------- | | ||||||
| | `-j, --job` | Job name | | ||||||
| | `-R, --registry` | Image registry (default: `quay.io`) | | ||||||
| | `-r, --repo` | Image repository (e.g., `rhdh/rhdh-hub-rhel9`) | | ||||||
| | `-t, --tag` | Image tag (e.g., `next`, `latest`, `1.5`) | | ||||||
| | `-p, --pr` | PR number (sets repo to `rhdh-community/rhdh`, tag to `pr-<number>`) | | ||||||
| | `-s, --skip-tests` | Deploy only, skip running tests | | ||||||
| | `-h, --help` | Show help message | | ||||||
| | Flag | Description | | ||||||
| | ------------------ | ------------------------------------------------------------------------ | | ||||||
| | `-j, --job` | Job name | | ||||||
| | `-R, --registry` | Image registry (default: `quay.io`) | | ||||||
| | `-r, --repo` | Image repository (e.g., `rhdh/rhdh-hub-rhel10` or `rhdh/rhdh-hub-rhel9`) | | ||||||
| | `-t, --tag` | Image tag (e.g., `next`, `latest`, `1.5`) | | ||||||
| | `-p, --pr` | PR number (sets repo to `rhdh-community/rhdh`, tag to `pr-<number>`) | | ||||||
| | `-s, --skip-tests` | Deploy only, skip running tests | | ||||||
| | `-h, --help` | Show help message | | ||||||
|
|
||||||
| --- | ||||||
|
|
||||||
|
|
@@ -301,11 +305,12 @@ All job types are supported as long as you're logged into the target cluster (`o | |||||
|
|
||||||
| #### Image Repositories | ||||||
|
|
||||||
| | Option | Repository | Description | | ||||||
| | ------ | --------------------- | ------------------------- | | ||||||
| | 1 | `rhdh-community/rhdh` | Community image (default) | | ||||||
| | 2 | `rhdh/rhdh-hub-rhel9` | Red Hat official image | | ||||||
| | 3 | Custom | Enter your own repository | | ||||||
| | Option | Repository | Description | | ||||||
| | ------ | ---------------------- | ------------------------------------ | | ||||||
| | 1 | `rhdh-community/rhdh` | Community image (default) | | ||||||
| | 2 | `rhdh/rhdh-hub-rhel10` | Red Hat RHEL 10 image (`main` / 2.y) | | ||||||
| | 3 | `rhdh/rhdh-hub-rhel9` | Red Hat RHEL 9 image (maintenance) | | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| | 4 | Custom | Enter your own repository | | ||||||
|
|
||||||
| #### Image Tags | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.