Skip to content

fix(#3788): replace clickBtnInCard with auto-retrying locator #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(#3788): replace clickBtnInCard with auto-retrying locator #3791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion workspaces/backstage/e2e-tests/tests/specs/gitlab-scaffolder-actions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ async function runScaffolderTemplate(
fillParameters: () => Promise<void>,
): Promise<void> {
await uiHelper.verifyHeading("Templates");
await uiHelper.clickBtnInCard(templateTitle, "Choose");
await page
.locator('div[class*="MuiCard-root"]')
.filter({ hasText: templateTitle })
.getByRole("button", { name: "Choose" })

@fullsend-ai-review fullsend-ai-review Bot Sep 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] edge-case

The locator chain does not include .first(), unlike the equivalent fix already landed in the orchestrator workspace (orchestrator-po.ts:383). Without .first(), Playwright operates in strict mode — if filter({ hasText: templateTitle }) ever matches more than one card (e.g., a template title is a substring of another card's text), the .click() will throw a strict-mode violation.

Suggested fix: Append .first() before .click(), consistent with the orchestrator pattern.

.click();
await uiHelper.waitForTitle(templateTitle, 2);
await fillParameters();
const reviewButton = page.getByRole("button", { name: "Review" });
Expand Down
Loading