Skip to content

fix(#3694): bulk-import E2E NFS sidebar nav and orchestrator skip - #3717

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3694-bulk-import-e2e-fixes
Open

fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3694-bulk-import-e2e-fixes

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Replace uiHelper.openSidebar("Catalog") with page.goto("/catalog") in the "Verify Added Repositories" test to avoid NFS global header overlay interception in bulk-import-app-next. Remove redundant openSidebar("Catalog") before page.goto in "Catalog-imported repo" test. Add test.skip guard for nightly mode in orchestrator "should interact with plugin features" test for product bug (TypeError at router.cjs.js:616).

Re-applies validated fix from PR #3337, closed without merge due to pipeline issues.


Closes #3694

Post-script verification

  • Branch is not main/master (agent/3694-bulk-import-e2e-fixes)
  • Secret scan passed (gitleaks — 867ccab30b5496862b752cb772d6a814f3216109..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Replace uiHelper.openSidebar("Catalog") with page.goto("/catalog")
in the "Verify Added Repositories" test to avoid NFS global header
overlay interception in bulk-import-app-next. Remove redundant
openSidebar("Catalog") before page.goto in "Catalog-imported repo"
test. Add test.skip guard for nightly mode in orchestrator "should
interact with plugin features" test for product bug (TypeError at
router.cjs.js:616).

Re-applies validated fix from PR #3337, closed without merge due
to pipeline issues.

Closes #3694
@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown

Hi @fullsend-ai-coder[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 9, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:55 AM UTC · Completed 12:05 PM UTC

Commit: cd48aee · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $2.01

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Low

  • [naming-conventions] workspaces/bulk-import/e2e-tests/tests/specs/bulk-import.spec.ts:238 — The new page.goto("/catalog") call introduces the only hardcoded route string among all page.goto() calls in the bulk-import e2e test suite. Every other page.goto() call uses a named constant or helper function (CATALOG_IMPORT_ROUTE, BULK_IMPORT_ROUTE, catalogDefaultComponentPath(), bulkImportImportHistoryPath()). However, the code it replaces (uiHelper.openSidebar("Catalog")) also used a hardcoded string, and /catalog is a core Backstage route unlikely to change.
    Remediation: Define a CATALOG_ROUTE constant in workspaces/bulk-import/e2e-tests/support/constants/catalog.ts (alongside the existing CATALOG_IMPORT_ROUTE) and import/use it here.

Labels: PR modifies E2E test files in an existing workspace to fix test failures.

uiHelper,
}) => {
await uiHelper.openSidebar("Catalog");
await page.goto("/catalog");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] naming-conventions

The new page.goto("/catalog") call introduces the only hardcoded route string among all page.goto() calls in the bulk-import e2e test suite. Every other page.goto() call uses a named constant or helper function (CATALOG_IMPORT_ROUTE, BULK_IMPORT_ROUTE, catalogDefaultComponentPath(), bulkImportImportHistoryPath()). However, the code it replaces (uiHelper.openSidebar("Catalog")) also used a hardcoded string, and /catalog is a core Backstage route unlikely to change.

Suggested fix: Define a CATALOG_ROUTE constant in workspaces/bulk-import/e2e-tests/support/constants/catalog.ts (alongside the existing CATALOG_IMPORT_ROUTE) and import/use it here.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge workspace-update PR modifies files in an existing workspace bug Something isn't working labels Sep 9, 2026
@github-actions github-actions Bot added the mandatory-workspace PR affects a workspace with required plugins for releases label Sep 9, 2026
@openshift-ci

openshift-ci Bot commented Sep 20, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working mandatory-workspace PR affects a workspace with required plugins for releases needs-ok-to-test needs-rebase ready-for-merge All reviewers approved — ready to merge workspace-update PR modifies files in an existing workspace

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply bulk-import E2E fixes for NFS sidebar navigation and orchestrator nightly skip

0 participants