forked from janus-idp/helm-backstage
-
Notifications
You must be signed in to change notification settings - Fork 39
feat(rhdh): add base NetworkPolicies for RHDH deployment [RHIDP-16476] #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rm3l
wants to merge
12
commits into
redhat-developer:main
Choose a base branch
from
rm3l:RHIDP-16476--implement-base-networkpolicies-for-rhdh-helm-chart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+582
−4
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2378706
feat(rhdh): add base NetworkPolicies for RHDH deployment [RHIDP-16476]
rm3l e753e87
fix(rhdh): fix helm lint YAML separator error in network-policies
rm3l 90dc998
fix(rhdh): fix helm lint YAML separator error in network-policies
rm3l e4fd573
fix(rhdh): allow test-connection pod through NetworkPolicies
rm3l 0ca53f0
fix(rhdh): allow backend ingress from test-connection pod
rm3l 27c9ef7
chore(rhdh): add TODO and inline comments to orchestrator NPs
rm3l 05ac8bc
feat(rhdh): add Redis egress rule (port 6379) to backend NPs
rm3l 4125412
fix(rhdh): fix whitespace trimming merging allow-https-egress with se…
rm3l c9b6125
refactor(rhdh): use YAML comments instead of Go template comments in NPs
rm3l a654f04
fix(rhdh): add missing read replica ingress NP from primary
rm3l 616ac88
Merge branch 'main' into RHIDP-16476--implement-base-networkpolicies-…
rm3l 1cc9f34
fix(rhdh): allow metrics ingress from openshift-user-workload-monitoring
rm3l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a patch bump instead? if we are following the rhdh release version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a coincidence actually :) It is required to bump the chart version whenever it changes in the upstream repo (so Helm chart-testing can test upgrades in CI). So we may be using a completely different version than RHDH.
But in the midstream pipelines, the chart version gets replaced to align with the RHDH version before packaging and shipping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So from a strict semver perspective, a minor bump makes sense in this upstream PR IMO.