[release-4.18] OCPBUGS-86553: Fix cloud-event-proxy deadlock and back…

[jzding]

Fix cloud-event-proxy deadlock and backport SyncStateChange fix.

Cherry-pick of #682 from release-4.19 with manual conflict resolution for release-4.18.

Conflicts resolved:

• pkg/common/common.go: Applied non-blocking SendToChannel to both V1 (EventInCh) and V2 (EventOutCh) code paths, preserving the IsV1Api branch that was removed in 4.19.
• cmd/main_test.go: Kept plugins.Handler (needed for HTTP plugin loading on 4.18) while using tempDir for test isolation.
• pkg/common/common_test.go: Added APIVersion arg to NewPubSub call (required on 4.18, removed in 4.19).

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jzding]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Enterprise

Run ID: a4cad3dc-f94a-4bcb-b206-b51ab793719d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@jzding: This pull request references Jira Issue OCPBUGS-85780, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected dependent Jira Issue OCPBUGS-77881 to target a version in 4.19.0, 4.19.z, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-86305, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
• expected dependent Jira Issue OCPBUGS-82536 to target a version in 4.19.0, 4.19.z, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…port SyncStateChange fix

Cherry-pick of a71314f from release-4.19 with manual conflict resolution for release-4.18.

Conflicts resolved:

• pkg/common/common.go: Applied non-blocking SendToChannel to both V1 (EventInCh) and V2 (EventOutCh) code paths, preserving the IsV1Api branch that was removed in 4.19.
• cmd/main_test.go: Kept plugins.Handler (needed for HTTP plugin loading on 4.18) while using tempDir for test isolation.
• pkg/common/common_test.go: Added APIVersion arg to NewPubSub call (required on 4.18, removed in 4.19).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jzding: This pull request references Jira Issue OCPBUGS-85780, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected dependent Jira Issue OCPBUGS-77881 to target a version in 4.19.0, 4.19.z, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-86305, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
• expected dependent Jira Issue OCPBUGS-82536 to target a version in 4.19.0, 4.19.z, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

…port SyncStateChange fix

Cherry-pick of a71314fe from release-4.19 with manual conflict resolution for release-4.18.

Conflicts resolved:

• pkg/common/common.go: Applied non-blocking SendToChannel to both V1 (EventInCh) and V2 (EventOutCh) code paths, preserving the IsV1Api branch that was removed in 4.19.
• cmd/main_test.go: Kept plugins.Handler (needed for HTTP plugin loading on 4.18) while using tempDir for test isolation.
• pkg/common/common_test.go: Added APIVersion arg to NewPubSub call (required on 4.18, removed in 4.19).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jzding: This pull request references Jira Issue OCPBUGS-86553, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
• expected Jira Issue OCPBUGS-86553 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…port SyncStateChange fix

Cherry-pick of #682 from release-4.19 with manual conflict resolution for release-4.18.

Conflicts resolved:

• pkg/common/common.go: Applied non-blocking SendToChannel to both V1 (EventInCh) and V2 (EventOutCh) code paths, preserving the IsV1Api branch that was removed in 4.19.
• cmd/main_test.go: Kept plugins.Handler (needed for HTTP plugin loading on 4.18) while using tempDir for test isolation.
• pkg/common/common_test.go: Added APIVersion arg to NewPubSub call (required on 4.18, removed in 4.19).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jzding]

/jira refresh

[openshift-ci-robot]

@jzding: This pull request references Jira Issue OCPBUGS-86553, which is invalid:

• expected dependent Jira Issue OCPBUGS-86305 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.