Skip to content

fix(renovate): seperate lightspeed-stack package rules#38

Merged
michael-valdron merged 1 commit into
redhat-ai-dev:mainfrom
michael-valdron:fix-renovate-1
Jul 10, 2026
Merged

fix(renovate): seperate lightspeed-stack package rules#38
michael-valdron merged 1 commit into
redhat-ai-dev:mainfrom
michael-valdron:fix-renovate-1

Conversation

@michael-valdron

@michael-valdron michael-valdron commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?:

Patch version enablement rule cannot be combined with the package version extraction rule, this is currently causing an error on renovate:

Location: 'renovate.json'

Error type: 'The renovate configuration file contains some invalid settings'

Message: 'packageRules[4]: packageRules cannot combine both matchUpdateTypes and extractVersion. Rule: {"matchDepNames":["quay.io/lightspeed-core/lightspeed-stack"],"matchBaseBranches":["/^release-\d+\.\d+$/"],"matchUpdateTypes":["patch"],"extractVersion":"^(?<version>\d+\.\d+\.\d+)","versioning":"loose","enabled":true}, packageRules[4]: packageRules cannot combine both matchUpdateTypes and versioning. Rule: {"matchDepNames":["quay.io/lightspeed-core/lightspeed-stack"],"matchBaseBranches":["/^release-\d+\.\d+$/"],"matchUpdateTypes":["patch"],"extractVersion":"^(?<version>\d+\.\d+\.\d+)","versioning":"loose","enabled":true}'

This PR fixes this issue by separating them into two different package rules.

Which issue(s) this PR fixes:

fixes #37

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

…sion extraction rule

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
michael-valdron requested a review from a team July 8, 2026 19:09
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix Renovate lightspeed-stack rules by separating patch enablement and version extraction

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Split lightspeed-stack Renovate package rules to satisfy config validation.
• Separate patch-update enablement from version extraction/versioning settings.
• Unblocks Renovate runs on release branches.
Diagram

graph TD
  R["Renovate Bot"] --> C["renovate.json"] --> PR1["Rule: patch enable"] --> REG["Container registry"]
  C --> PR2["Rule: extract version"] --> REG
Loading
High-Level Assessment

The chosen approach is the correct Renovate configuration fix: Renovate forbids combining matchUpdateTypes with extractVersion/versioning in the same packageRule, so splitting the concerns into two rules is the simplest and most maintainable solution.

Files changed (1) +6 / -2

Other (1) +6 / -2
renovate.jsonSplit lightspeed-stack packageRule to avoid Renovate config validation errors +6/-2

Split lightspeed-stack packageRule to avoid Renovate config validation errors

• Separates the lightspeed-stack patch-update enablement rule from the extractVersion/versioning rule. This prevents Renovate from rejecting the configuration due to incompatible fields in a single packageRule.

renovate.json

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@michael-valdron
michael-valdron merged commit 21d09f7 into redhat-ai-dev:main Jul 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action Required: Fix Renovate Configuration

2 participants