This repository was archived by the owner on Jun 7, 2026. It is now read-only.
Fix start-proxy.js flag-parse crash (standalone --mode/--port)#1
Draft
redact22 wants to merge 1 commit into
Draft
Fix start-proxy.js flag-parse crash (standalone --mode/--port)#1redact22 wants to merge 1 commit into
redact22 wants to merge 1 commit into
Conversation
start-proxy.js treated argv[2]/argv[3] as the legacy <url> <key> positionals
before checking for flags, so 'node start-proxy.js --mode deepseek --port 3200'
crashed with new URL('--mode'). Standalone flag mode was unreachable. Now ignores
leading flags; legacy mode (real url+key) is unchanged.
(Same fix already applied in the hydra deepclaude.)
https://claude.ai/code/session_01QudvzQk8mSQd3xrQwmX93D
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of the $20-plan downgrade prep.
redact22/deepclaudeis the simpler public sibling of the hydra deepclaude; the owner runsdeepclaudeand shouldn't hit a crash whichever copy launches.The bug
proxy/start-proxy.jsreadargv[2]/argv[3]as the legacy<url> <key>positionals before checking for flags, sonode start-proxy.js --mode deepseek --port 3200was treated as legacy mode withtargetUrl = "--mode"→new URL('--mode')crash. Standalone flag mode was unreachable.Fix
Only treat the first two args as url/key when they are not flags (
startsWith('-')). Legacy mode (deepclaude.sh/ps1passing a real url + key) is unchanged. Verified: standalone--mode/--portnow starts and listens; legacy still works.This is the same fix already applied in the hydra deepclaude (PR aattaran#9). The hydra copy is the canonical, full-featured one; this keeps the sibling from crashing in standalone mode.
https://claude.ai/code/session_01QudvzQk8mSQd3xrQwmX93D
Generated by Claude Code