Repository navigation
OTHER: Document HMR-only unmount guards and exclude them from coverage - #1
Merged
Merged
Conversation
The isSkipped/abort guard in useAsync and wasAction reset in useAutoAsync protect against hot module reloading rerunning an effect without a real unmount/remount. Document why, and mark these branches v8-ignored since they can't be exercised in a unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isSkipped/abortguard inuseAsyncandwasActionreset in useAutoAsync protect against hot module reloading rerunning an effect without a real unmount/remount. Document why, and mark these branches v8-ignored since they can't be exercised in a unit test