-
Notifications
You must be signed in to change notification settings - Fork 37
feat(oas-to-har): retain null values in array #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oas-to-har): retain null values in array #998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we vendoring and forking remove-undefined-objects in here instead of adding a new option to that library for preserving empty arrays? thats what @mjcuva and i talked about out what i thought needed to happen for this ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kanadgupta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use the latest release of remove-undefined-objects@7.0.0 here?
🧰 Changes
This PR is part of the work for the readme ticket RM-9906 Not displaying null values in an array and should get merged ONLY after the corresponding PR changes in the
remove-undefined-objectsrepo is shippedThe aim of the ticket is we want user-added null values in arrays to be visible in requests.
This requires adjustments in the oas-to-har package, with two separate causes of why the nulls in array are being dropped
Updated stripEmptyObjects to stop removing null values in arrays, while still removing undefined, empty objects, and empty arrays.
TODO Before Merging:
🧬 QA & Testing