Expose the reading order rendered by the navigator - #901
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementations accurately expose each navigator’s rendered reading order with a focused, consistent refactor.
Pull request overview
Exposes each navigator’s effective reading order, including EPUB custom orders and selected resource variants.
Changes:
- Adds
Navigator.readingOrder. - Implements it for EPUB, PDF, and audiobook navigators.
- Documents the new API in the changelog.
File summaries
| File | Description |
|---|---|
Sources/Navigator/Navigator.swift |
Defines the new protocol property. |
Sources/Navigator/EPUB/EPUBNavigatorViewController.swift |
Exposes and consistently uses rendered EPUB links. |
Sources/Navigator/PDF/PDFNavigatorViewController.swift |
Returns the publication’s PDF reading order. |
Sources/Navigator/Audiobook/AudioNavigator.swift |
Returns the publication’s audio reading order. |
CHANGELOG.md |
Records the new navigator API. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Navigator
Navigator.readingOrderproperty returning the reading order actually rendered by the navigator, which may differ frompublication.readingOrderwhen a custom reading order or a resource variant is used.