-
Notifications
You must be signed in to change notification settings - Fork 246
Fix PDF navigator content inset on iOS 27 #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
705b7b0
Fix launching the Test App on iOS 27
mickael-menu 4598af9
Fix PDF content being inset by the navigation bar on iOS 27
mickael-menu 16fdb3d
Fix presentation of the reader
mickael-menu f8cbc89
Update the changelog
mickael-menu fb5fe4c
Fix
mickael-menu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| // | ||
| // Copyright 2026 Readium Foundation. All rights reserved. | ||
| // Use of this source code is governed by the BSD-style license | ||
| // available in the top-level LICENSE file of the project. | ||
| // | ||
|
|
||
| import ReadiumShared | ||
| import UIKit | ||
|
|
||
| class SceneDelegate: UIResponder, UIWindowSceneDelegate { | ||
| var window: UIWindow? | ||
|
|
||
| private var app: AppModule { | ||
| AppDelegate.app | ||
| } | ||
|
|
||
| func scene( | ||
| _ scene: UIScene, | ||
| willConnectTo session: UISceneSession, | ||
| options connectionOptions: UIScene.ConnectionOptions | ||
| ) { | ||
| guard let windowScene = scene as? UIWindowScene else { | ||
| return | ||
| } | ||
|
|
||
| func makeItem(title: String, image: String) -> UITabBarItem { | ||
| UITabBarItem( | ||
| title: NSLocalizedString(title, comment: "Library tab title"), | ||
| image: UIImage(named: image), | ||
| tag: 0 | ||
| ) | ||
| } | ||
|
|
||
| // Library | ||
| let libraryViewController = app.library.rootViewController | ||
| libraryViewController.tabBarItem = makeItem(title: "bookshelf_tab", image: "bookshelf") | ||
|
|
||
| // OPDS Feeds | ||
| let opdsViewController = app.opds.rootViewController | ||
| opdsViewController.tabBarItem = makeItem(title: "catalogs_tab", image: "catalogs") | ||
|
|
||
| // About | ||
| let aboutViewController = app.aboutViewController | ||
| aboutViewController.tabBarItem = makeItem(title: "about_tab", image: "about") | ||
|
|
||
| let tabBarController = UITabBarController() | ||
| tabBarController.viewControllers = [ | ||
| libraryViewController, | ||
| opdsViewController, | ||
| aboutViewController, | ||
| ] | ||
|
|
||
| let window = UIWindow(windowScene: windowScene) | ||
| window.rootViewController = tabBarController | ||
| window.makeKeyAndVisible() | ||
| self.window = window | ||
|
|
||
| // The scene can be launched by opening a publication, in which case | ||
| // the URLs are delivered here instead of `scene(_:openURLContexts:)`. | ||
| importPublications(from: connectionOptions.urlContexts) | ||
| } | ||
|
|
||
| func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) { | ||
| importPublications(from: URLContexts) | ||
| } | ||
|
|
||
| private func importPublications(from contexts: Set<UIOpenURLContext>) { | ||
| for context in contexts { | ||
| guard let url = context.url.anyURL.absoluteURL else { | ||
| continue | ||
| } | ||
|
|
||
| Task { | ||
| do { | ||
| try await app.library.importPublication(from: url, progress: { _ in }) | ||
| } catch { | ||
| guard | ||
| let error = error as? UserErrorConvertible, | ||
| let vc = window?.rootViewController | ||
| else { | ||
| print(error) | ||
| return | ||
| } | ||
| vc.alert(error) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.