add pyproject.toml for numpy requirement#272
Open
valrus wants to merge 1 commit intoreadbeyond:masterfrom
Open
add pyproject.toml for numpy requirement#272valrus wants to merge 1 commit intoreadbeyond:masterfrom
valrus wants to merge 1 commit intoreadbeyond:masterfrom
Conversation
danielbair
approved these changes
Jul 6, 2023
|
A recent update to setuptools broke this fix for me. I created a fork that fixes the issue by pinning setuptools to 75.8.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a pyproject.toml file to address the need to manually install numpy before aeneas, which was preventing aeneas from installing correctly in a Heroku app.
I took the approach from this PR on a project with the same issue. Based on the comments on that PR, it should work for any version of pip above 10 and be harmless for lower versions. I tested it in a Heroku deploy and was able to install aeneas directly from a requirements.txt file.