Skip to content

Feature/verifier#23

Merged
jweiser merged 10 commits into
mainfrom
feature/verifier
Dec 23, 2025
Merged

Feature/verifier#23
jweiser merged 10 commits into
mainfrom
feature/verifier

Conversation

@jweiser
Copy link
Copy Markdown
Member

@jweiser jweiser commented Dec 21, 2025

adds code to verify a correct run of the "diagram-converter" release step

Also:

  • updates POM file to build main and verifier jars
  • updates Dockerfile to include verifier jar file in image build
  • updates Jenkinsfile to run verifier code after diagram-converter step completes

@jweiser jweiser self-assigned this Dec 21, 2025
@jweiser jweiser added the enhancement New feature or request label Dec 21, 2025
Copy link
Copy Markdown
Contributor

@adamjohnwright adamjohnwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One thing I am wondering is if this graph database dump is the official one that is being put in the download directory. If it is, we could make sure the name of the pipeline in Jenkins indicates this. And or in the Release SOP make this clear. Not a big deal...just a thought. This pipeline is really doing two different things by creating the dump as well.

@jweiser
Copy link
Copy Markdown
Member Author

jweiser commented Dec 23, 2025

Looks great. One thing I am wondering is if this graph database dump is the official one that is being put in the download directory. If it is, we could make sure the name of the pipeline in Jenkins indicates this. And or in the Release SOP make this clear. Not a big deal...just a thought. This pipeline is really doing two different things by creating the dump as well.

@adamjohnwright Thanks! The database file created here is the gzipped tar file of the "graph.db" neo4j directory. The dump file is created later during the "finalize release", I believe. I agree that this step is really doing two different things. I'd like to break out the creation of the database gzipped tar file into its own step. I think it should have its own verification separate from the diagram creation.

@jweiser jweiser merged commit 676fcee into main Dec 23, 2025
3 checks passed
@jweiser jweiser deleted the feature/verifier branch December 23, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants