Feature/verifier#23
Conversation
adamjohnwright
left a comment
There was a problem hiding this comment.
Looks great. One thing I am wondering is if this graph database dump is the official one that is being put in the download directory. If it is, we could make sure the name of the pipeline in Jenkins indicates this. And or in the Release SOP make this clear. Not a big deal...just a thought. This pipeline is really doing two different things by creating the dump as well.
@adamjohnwright Thanks! The database file created here is the gzipped tar file of the "graph.db" neo4j directory. The dump file is created later during the "finalize release", I believe. I agree that this step is really doing two different things. I'd like to break out the creation of the database gzipped tar file into its own step. I think it should have its own verification separate from the diagram creation. |
adds code to verify a correct run of the "diagram-converter" release step
Also: