First step to target fully source gen implementation#1746
Open
kant2002 wants to merge 9 commits intoreactiveui:mainfrom
Open
First step to target fully source gen implementation#1746kant2002 wants to merge 9 commits intoreactiveui:mainfrom
kant2002 wants to merge 9 commits intoreactiveui:mainfrom
Conversation
I extract simple model for Refit client representation withing source gen That to allow facilitate process - Parse Syntax (done by Roslyn itslef) - Build internal model - Write based on model only, so logic would be as simple as possible Also that allows write more robust test if we test just internal model extraction from symbols. Otherwise if we will capture generated output, if we decide improve generation it will produce a lot of churn. I do not agains churn like that, but not sure that's would be appropriate.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
- Coverage 87.73% 83.66% -4.08%
==========================================
Files 33 36 +3
Lines 2348 2442 +94
Branches 294 345 +51
==========================================
- Hits 2060 2043 -17
- Misses 208 316 +108
- Partials 80 83 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extract simple model for Refit client representation withing source gen That to allow facilitate process
Also that allows write more robust test if we test just internal model extraction from symbols. Otherwise if we will capture generated output, if we decide improve generation it will produce a lot of churn. I do not agains churn like that, but not sure that's would be appropriate.
Related to #1389