Make CustomEventNamesResolver a fun interface for SAM conversion#57112
Closed
cortinico wants to merge 1 commit into
Closed
Make CustomEventNamesResolver a fun interface for SAM conversion#57112cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Summary:
`UIManagerModule` was recently converted from Java to Kotlin. The nested
`CustomEventNamesResolver` interface has a single abstract method, but
was declared as a regular `interface` rather than `fun interface`.
In Java, single-method interfaces support SAM (Single Abstract Method)
conversion in Kotlin callers. After the Kotlin conversion, SAM conversion
no longer works unless the interface is declared as `fun interface`.
This breaks downstream libraries like `react-native-reanimated` that use
lambda syntax to instantiate `CustomEventNamesResolver`:
```
UIManagerModule.CustomEventNamesResolver { eventName -> ... }
```
Adding `fun` restores SAM conversion support. This is backward compatible
— existing `object : CustomEventNamesResolver { ... }` code continues to work.
Differential Revision: D107891295
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107891295. |
|
This pull request has been merged in df4cadc. |
Collaborator
|
This pull request was successfully merged by @cortinico in df4cadc When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
UIManagerModulewas recently converted from Java to Kotlin. The nestedCustomEventNamesResolverinterface has a single abstract method, butwas declared as a regular
interfacerather thanfun interface.In Java, single-method interfaces support SAM (Single Abstract Method)
conversion in Kotlin callers. After the Kotlin conversion, SAM conversion
no longer works unless the interface is declared as
fun interface.This breaks downstream libraries like
react-native-reanimatedthat uselambda syntax to instantiate
CustomEventNamesResolver:Adding
funrestores SAM conversion support. This is backward compatible— existing
object : CustomEventNamesResolver { ... }code continues to work.Differential Revision: D107891295