Skip to content

Commit 25d501d

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Annotate LegacyArchitecture classes for com/facebook/react/uimanager package (#49764)
Summary: Pull Request resolved: #49764 Annotate LegacyArchitecture classes for com/facebook/react/uimanager package changelog: [internal] internal Reviewed By: rshest Differential Revision: D70441495 fbshipit-source-id: fd3e5b3a40dffc31197df2153cde528bc723a2ab
1 parent 8254758 commit 25d501d

18 files changed

Lines changed: 40 additions & 1 deletion

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/LayoutDirectionUtil.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@
88
package com.facebook.react.uimanager
99

1010
import android.view.View
11+
import com.facebook.react.common.annotations.internal.LegacyArchitecture
1112
import com.facebook.yoga.YogaDirection
1213

14+
@LegacyArchitecture
1315
internal object LayoutDirectionUtil {
1416
@JvmStatic
1517
fun toAndroidFromYoga(direction: YogaDirection): Int =

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/LayoutShadowNode.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import com.facebook.react.bridge.Dynamic;
1313
import com.facebook.react.bridge.ReadableType;
1414
import com.facebook.react.common.ReactConstants;
15+
import com.facebook.react.common.annotations.internal.LegacyArchitecture;
1516
import com.facebook.react.modules.i18nmanager.I18nUtil;
1617
import com.facebook.react.uimanager.annotations.ReactProp;
1718
import com.facebook.react.uimanager.annotations.ReactPropGroup;
@@ -34,6 +35,7 @@
3435
* may or may not be embedded in a parent text. There are better solutions that should probably be
3536
* explored, namely using the VirtualText class in JS and setting the correct set of validAttributes
3637
*/
38+
@LegacyArchitecture
3739
public class LayoutShadowNode extends ReactShadowNodeImpl {
3840

3941
/** A Mutable version of com.facebook.yoga.YogaValue */

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeKind.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77

88
package com.facebook.react.uimanager
99

10+
import com.facebook.react.common.annotations.internal.LegacyArchitecture
11+
1012
// Common conditionals:
1113
// - `kind == PARENT` checks whether the node can host children in the native tree.
1214
// - `kind != NONE` checks whether the node appears in the native tree.
13-
15+
@LegacyArchitecture
1416
internal enum class NativeKind {
1517
// Node is in the native hierarchy and the HierarchyOptimizer should assume it can host children
1618
// (e.g. because it's a ViewGroup). Note that it's okay if the node doesn't support children. When

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.facebook.react.bridge.RetryableMountingLayerException;
2727
import com.facebook.react.bridge.SoftAssertions;
2828
import com.facebook.react.bridge.UiThreadUtil;
29+
import com.facebook.react.common.annotations.internal.LegacyArchitecture;
2930
import com.facebook.react.common.build.ReactBuildConfig;
3031
import com.facebook.react.touch.JSResponderHandler;
3132
import com.facebook.react.uimanager.layoutanimation.LayoutAnimationController;
@@ -64,6 +65,7 @@
6465
* <p>TODO(5483031): Only dispatch updates when shadow views have changed
6566
*/
6667
@NotThreadSafe
68+
@LegacyArchitecture
6769
public class NativeViewHierarchyManager {
6870

6971
private static final String TAG = NativeViewHierarchyManager.class.getSimpleName();

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyOptimizer.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import com.facebook.infer.annotation.Assertions;
1414
import com.facebook.react.bridge.ReadableArray;
1515
import com.facebook.react.bridge.ReadableMapKeySetIterator;
16+
import com.facebook.react.common.annotations.internal.LegacyArchitecture;
1617

1718
/**
1819
* Class responsible for optimizing the native view hierarchy while still respecting the final UI
@@ -45,6 +46,7 @@
4546
* manageChildren calls for various parent views may be issued to the native view hierarchy
4647
* depending on where the views being added/removed are attached in the optimized hierarchy
4748
*/
49+
@LegacyArchitecture
4850
public class NativeViewHierarchyOptimizer {
4951

5052
private static final String TAG = "NativeViewHierarchyOptimizer";

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/NoSuchNativeViewException.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,12 @@
77

88
package com.facebook.react.uimanager
99

10+
import com.facebook.react.common.annotations.internal.LegacyArchitecture
11+
1012
/**
1113
* Exception thrown when a class tries to access a native view by a tag that has no native view
1214
* associated with it.
1315
*/
16+
@LegacyArchitecture
1417
internal class NoSuchNativeViewException(detailMessage: String) :
1518
IllegalViewOperationException(detailMessage)

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/OnLayoutEvent.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@
1212
import com.facebook.infer.annotation.Nullsafe;
1313
import com.facebook.react.bridge.Arguments;
1414
import com.facebook.react.bridge.WritableMap;
15+
import com.facebook.react.common.annotations.internal.LegacyArchitecture;
1516
import com.facebook.react.uimanager.events.Event;
1617

1718
/** Event used to notify JS component about changes of its position or dimensions */
1819
@Nullsafe(Nullsafe.Mode.LOCAL)
20+
@LegacyArchitecture
1921
public class OnLayoutEvent extends Event<OnLayoutEvent> {
2022

2123
private static final Pools.SynchronizedPool<OnLayoutEvent> EVENTS_POOL =

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNode.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
package com.facebook.react.uimanager;
99

1010
import androidx.annotation.Nullable;
11+
import com.facebook.react.common.annotations.internal.LegacyArchitecture;
1112
import com.facebook.yoga.YogaAlign;
1213
import com.facebook.yoga.YogaBaselineFunction;
1314
import com.facebook.yoga.YogaDirection;
@@ -44,6 +45,7 @@
4445
* separately native children (e.g. {@link #getNativeChildCount()}). See {@link
4546
* NativeViewHierarchyOptimizer} for more information.
4647
*/
48+
@LegacyArchitecture
4749
public interface ReactShadowNode<T extends ReactShadowNode> {
4850

4951
/**

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNodeImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
import androidx.annotation.Nullable;
1111
import com.facebook.infer.annotation.Assertions;
12+
import com.facebook.react.common.annotations.internal.LegacyArchitecture;
1213
import com.facebook.react.uimanager.annotations.ReactPropertyHolder;
1314
import com.facebook.yoga.YogaAlign;
1415
import com.facebook.yoga.YogaBaselineFunction;
@@ -54,6 +55,7 @@
5455
* NativeViewHierarchyOptimizer} for more information.
5556
*/
5657
@ReactPropertyHolder
58+
@LegacyArchitecture
5759
public class ReactShadowNodeImpl implements ReactShadowNode<ReactShadowNodeImpl> {
5860

5961
private static final YogaConfig sYogaConfig;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactYogaConfigProvider.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77

88
package com.facebook.react.uimanager
99

10+
import com.facebook.react.common.annotations.internal.LegacyArchitecture
1011
import com.facebook.yoga.YogaConfig
1112
import com.facebook.yoga.YogaConfigFactory
1213
import com.facebook.yoga.YogaErrata
1314

15+
@LegacyArchitecture
1416
internal object ReactYogaConfigProvider {
1517

1618
val yogaConfig: YogaConfig by

0 commit comments

Comments
 (0)