Annotate Legacy Architecture classes of com/facebook/react (#49765)

Summary:
Pull Request resolved: #49765

Annotate Legacy Architecture classes of com/facebook/react

changelog: [internal] internal

Reviewed By: rshest

Differential Revision: D70441494

fbshipit-source-id: bc677ce508a0d119258819fc6a02d339dc5d8e9a

Author: mdvacca

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java

@@ -17,6 +17,7 @@
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactMarker;
 import com.facebook.react.common.ClassFinder;
+import com.facebook.react.common.annotations.internal.LegacyArchitecture;
 import com.facebook.react.devsupport.LogBoxModule;
 import com.facebook.react.module.annotations.ReactModule;
 import com.facebook.react.module.annotations.ReactModuleList;
@@ -59,6 +60,7 @@
       TimingModule.class,
       UIManagerModule.class,
     })
+@LegacyArchitecture
 class CoreModulesPackage extends BaseReactPackage implements ReactPackageLogger {
 
   private final ReactInstanceManager mReactInstanceManager;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/JSEngineResolutionAlgorithm.kt

@@ -6,11 +6,15 @@
  */
 
 package com.facebook.react
+
+import com.facebook.react.common.annotations.internal.LegacyArchitecture
+
 /**
  * An enum that specifies the algorithm to use when loading theJS Engine. [.JSC] will load
  * JavaScriptCore first and fail if it is not available. [.HERMES] will load Hermes first and fail
  * if it is not available.
  */
+@LegacyArchitecture
 public enum class JSEngineResolutionAlgorithm {
   JSC,
   HERMES

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.java

@@ -15,6 +15,7 @@
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactMarker;
 import com.facebook.react.bridge.ReactMarkerConstants;
+import com.facebook.react.common.annotations.internal.LegacyArchitecture;
 import com.facebook.react.module.model.ReactModuleInfo;
 import com.facebook.react.module.model.ReactModuleInfoProvider;
 import com.facebook.react.uimanager.ViewManager;
@@ -27,6 +28,7 @@
 
 /** React package supporting lazy creation of native modules. */
 @Deprecated(since = "This class is deprecated, please use BaseReactPackage instead.")
+@LegacyArchitecture
 public abstract class LazyReactPackage implements ReactPackage {
 
   /**

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/NativeModuleRegistryBuilder.kt

@@ -10,8 +10,10 @@ package com.facebook.react
 import com.facebook.react.bridge.ModuleHolder
 import com.facebook.react.bridge.NativeModuleRegistry
 import com.facebook.react.bridge.ReactApplicationContext
+import com.facebook.react.common.annotations.internal.LegacyArchitecture
 
 /** Helper class to build NativeModuleRegistry. */
+@LegacyArchitecture
 public class NativeModuleRegistryBuilder(
     private val reactApplicationContext: ReactApplicationContext,
 ) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

@@ -78,6 +78,7 @@
 import com.facebook.react.common.SurfaceDelegateFactory;
 import com.facebook.react.common.annotations.StableReactNativeAPI;
 import com.facebook.react.common.annotations.VisibleForTesting;
+import com.facebook.react.common.annotations.internal.LegacyArchitecture;
 import com.facebook.react.devsupport.DevSupportManagerFactory;
 import com.facebook.react.devsupport.InspectorFlags;
 import com.facebook.react.devsupport.ReactInstanceDevHelper;
@@ -143,6 +144,7 @@
  */
 @ThreadSafe
 @StableReactNativeAPI
+@LegacyArchitecture
 public class ReactInstanceManager {
 
   private static final String TAG = ReactInstanceManager.class.getSimpleName();

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java

@@ -25,6 +25,7 @@
 import com.facebook.react.common.LifecycleState;
 import com.facebook.react.common.SurfaceDelegateFactory;
 import com.facebook.react.common.annotations.StableReactNativeAPI;
+import com.facebook.react.common.annotations.internal.LegacyArchitecture;
 import com.facebook.react.devsupport.DefaultDevSupportManagerFactory;
 import com.facebook.react.devsupport.DevSupportManagerFactory;
 import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener;
@@ -44,6 +45,7 @@
 
 /** Builder class for {@link ReactInstanceManager} */
 @StableReactNativeAPI
+@LegacyArchitecture
 public class ReactInstanceManagerBuilder {
 
   private static final String TAG = ReactInstanceManagerBuilder.class.getSimpleName();

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java

@@ -19,6 +19,7 @@
 import com.facebook.react.common.SurfaceDelegate;
 import com.facebook.react.common.SurfaceDelegateFactory;
 import com.facebook.react.common.annotations.DeprecatedInNewArchitecture;
+import com.facebook.react.common.annotations.internal.LegacyArchitecture;
 import com.facebook.react.devsupport.DevSupportManagerFactory;
 import com.facebook.react.devsupport.interfaces.DevLoadingViewManager;
 import com.facebook.react.devsupport.interfaces.PausedInDebuggerOverlayManager;
@@ -34,6 +35,7 @@
     message =
         "This class will be replaced by com.facebook.react.ReactHost in the new architecture of"
             + " React Native.")
+@LegacyArchitecture
 public abstract class ReactNativeHost {
 
   private final Application mApplication;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageHelper.kt

@@ -19,7 +19,6 @@ internal object ReactPackageHelper {
    *
    * @param reactPackage
    * @param reactApplicationContext
-   * @param reactInstanceManager
    * @return
    */
   fun getNativeModuleIterator(