Skip to content

[Documentation] TalkBack support for ScrollView accessibility announcements (list and grid)#3205

Closed
fabOnReact wants to merge 3 commits into
react:mainfrom
fabOnReact:scroll-view-accessibility-collection
Closed

[Documentation] TalkBack support for ScrollView accessibility announcements (list and grid)#3205
fabOnReact wants to merge 3 commits into
react:mainfrom
fabOnReact:scroll-view-accessibility-collection

Conversation

@fabOnReact

@fabOnReact fabOnReact commented Jul 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding documentation for PR react/react-native#33180
Not ready to merge as react/react-native#33180 was reverted

@netlify

netlify Bot commented Jul 11, 2022 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 404e392
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/62cba4453520d30008c8b9b5
😎 Deploy Preview https://deploy-preview-3205--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fabOnReact fabOnReact mentioned this pull request Jul 11, 2022
Closed
@Simek Simek added 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release. labels Jul 15, 2022
@fabOnReact fabOnReact marked this pull request as ready for review July 21, 2022 15:29
@fabOnReact fabOnReact marked this pull request as draft July 21, 2022 15:29
@fabOnReact fabOnReact changed the title TalkBack support for ScrollView accessibility announcements (list and grid) [Documentation] TalkBack support for ScrollView accessibility announcements (list and grid) Jul 22, 2022
@Simek Simek removed the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Jul 22, 2022
@Simek

Simek commented Jul 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@fabriziobertoglio1987 It looks like related PR has been merge and become a part of 0.70 RC, so it would be nice to ship this before new version docs cut.

Is there something what you would like to finish, or is this PR ready for review?

Edit: Oh, it has been reverted, just spotted that...

@fabOnReact

fabOnReact commented Aug 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Related react/react-native@3f8071d

D37668064 (react/react-native@463af23) caused issues in VR Store where on tail load, the scroll position would reset and go back to the top.

@fabOnReact fabOnReact marked this pull request as ready for review September 28, 2022 00:15
@Simek

Simek commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Hey @fabOnReact, according to react/react-native#56692 (comment) comment it looks like the changes were never re-shipped. Since someone else is currently working on a different implementation I'm going to close this PR, so we can avoid confusion. Feel free to reopen tho, if you decide to try landing your version once again.

@Simek Simek closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed Wait on future Release This indicates a PR that updates the doc to match a future release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabOnReact @Simek @facebook-github-bot