This repository was archived by the owner on May 20, 2021. It is now read-only.
Add restProps to anchor#12
Open
clementmoine wants to merge 1 commit intoreact-navigation:masterfrom
clementmoine:master
Open
Add restProps to anchor#12clementmoine wants to merge 1 commit intoreact-navigation:masterfrom clementmoine:master
clementmoine wants to merge 1 commit intoreact-navigation:masterfrom
clementmoine:master
Conversation
Add the restProps to anchor to allow params like `style`, `className` and many more !
ericvicenti
reviewed
Apr 17, 2019
| routeKey, | ||
| navigation, | ||
| action, | ||
| ...restProps, |
Contributor
There was a problem hiding this comment.
What if we renamed this to anchorProps, (with no "..." spreading) so that the use is explicit. I want to make sure we can add functionality to this component in the future, without breaking people's apps. This way we don't have the same namespace as the component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user is able to provide
style,onClickandclassNameparameters for example when creating aLinkfromreact-navigation-web.restPropsis meant to contain all props that are not already extracted fromthis.propsthat allow the user to choose wether he want to addclassName,onClick,stylefor any reason.Use case example :
Issue #5 is solved with this PR