This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Add repository info to package.json#69
Open
mrousavy wants to merge 2 commits intoreact-native-art:masterfrom
mrousavy:patch-1
Open
Add repository info to package.json#69mrousavy wants to merge 2 commits intoreact-native-art:masterfrom mrousavy:patch-1
mrousavy wants to merge 2 commits intoreact-native-art:masterfrom
mrousavy:patch-1
Conversation
Esemesek
suggested changes
Nov 9, 2020
Collaborator
Esemesek
left a comment
Esemesek
left a comment
There was a problem hiding this comment.
It is not really true anymore since we moved to a new organization. Can we update the url?
Author
|
@Esemesek I assume we don't want to change the package name, right? |
Collaborator
|
Yup, the package name stays the same for now. |
Esemesek
reviewed
Nov 9, 2020
| "author": "@react-native-community", | ||
| "homepage": "https://github.com/react-native-community/react-native-art", | ||
| "author": "react-native-art", | ||
| "homepage": "https://github.com/react-native-art/react-native-art", |
Collaborator
There was a problem hiding this comment.
https://github.com/react-native-art/art C:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the
repositoryproperty to the package.json.One problem with having no repository property is, that tools like license crawlers cannot read the creator and add repository links.
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)