Silence esbuild + workspace bin warnings on build - #33
Merged
Merged
Conversation
- allowlist esbuild in pnpm.onlyBuiltDependencies so its postinstall runs instead of being blocked (pnpm 10 default) - make root `build` a pure `turbo run build`; the previous `pnpm install && turbo run build` re-linked the cli's mcp-server bin before dist was built, triggering an ENOENT bin warning on clean trees (and in CI, which already installs before building) - add a `bootstrap` script for the one-shot install+build convenience Cosmetic only — published tarballs ship dist and the CLI imports startMcpServer directly rather than via the bin symlink. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves two cosmetic warnings seen when running
pnpm build.1.
Ignored build scripts: esbuild— pnpm 10 blocks dependency build scripts by default. esbuild (used by tsup) has apostinstall; added it topnpm.onlyBuiltDependenciesso it runs instead of being nagged about.2.
Failed to create bin … rag-eval-mcp-server … dist/bin.js— the rootbuildscript waspnpm install && turbo run build. On a clean tree (distabsent), the inlinepnpm installtried to symlink the CLI's dependency bin beforemcp-serverwas built. CI already installs before building (ci.yml), so that inline install was redundant and the source of the warning.buildis now a pureturbo run build(turbo buildsmcp-serverbeforeclivia the dep graph); the one-shot install+build flow is preserved as a newbootstrapscript.Neither warning affected published packages — the tarballs ship
dist, and the CLI importsstartMcpServerdirectly rather than via the bin symlink.Test plan
pnpm install— no esbuild warningrm -rf packages/mcp-server/dist && pnpm build— no bin warning, 10/10 taskspnpm typecheck,pnpm lint,pnpm test(20/20) — all green🤖 Generated with Claude Code