Skip to content

test: cover public library behavior - #83

Merged
rdlabo merged 2 commits into
mainfrom
test/library-minimum-coverage
Aug 22, 2026
Merged

test: cover public library behavior#83
rdlabo merged 2 commits into
mainfrom
test/library-minimum-coverage

Conversation

@rdlabo

@rdlabo rdlabo commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add minimum behavioral coverage for the public surfaces of kit, photo-editor, scroll-header, and scroll-strategies
  • cover editor/viewer inputs, labels, crop/filter/save/remove/zoom flows, lifecycle cleanup, browser/native file selection, scroll thresholds, virtual-scroll offsets, strategy boundaries, haptics, and component mounting
  • use real jsdom behavior where practical and assert side effects and boundary values instead of creation-only smoke tests
  • keep the suite free of focused or skipped specs

Bugs exposed and fixed by the tests

  • browser photo selection now settles on empty, invalid, aborted, read-failure, and resize-failure paths; the file input is cleared early enough to allow the same file to be selected again
  • smooth CDK virtual scrolling now updates only the active viewport orientation, preventing an X offset from overwriting a vertical Y offset

Test totals

Project Tests
demo 11
photo-editor 33
scroll-header 18
scroll-strategies 42
kit 944
Total 1,048

Verification

  • npm run lint
  • npm run test
  • npm run build
  • git diff --check
  • no .skip, .only, fit, or fdescribe
  • manager review: APPROVE after two fix-and-rereview cycles
  • OSS maintainer review: APPROVE after one fix-and-rereview cycle

@rdlabo
rdlabo merged commit 4c2c482 into main Aug 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant