feat(photo-editor)!: add explicit header schemes and prefixed selectors - #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
headerButtonColorScheme: 'light' | 'dark'for bothPhotoEditorPageandPhotoViewerPagecss/*exportrdlabo-photo-editorandrdlabo-photo-viewerBreaking changes
headerButtonColorSchemeis required inPhotoEditorPropsandPhotoViewerProps; consumers select the scheme matching the finalion-toolbarappearance.PhotoViewerProps.imageUrlsis now correctly typed as required, matching the existing required component input.<app-editor-image><rdlabo-photo-editor><app-photo-image><rdlabo-photo-viewer>ModalControllerconsumers that present the exported component classes do not need a selector-related change. Seedocs/migration.mdfor the complete consumer migration.Verification
npm run lintnpm run test(1,048/1,048: demo 11, photo-editor 33, scroll-header 18, scroll-strategies 42, kit 944)npm run prebuildnpm run buildnpx playwright test e2e/photo-editor-ios26.spec.ts(3/3)npm pack --dry-run ./dist/photo-editorimport.meta.resolvegit diff --check; no focused or skipped specs