refactor(kit): simplify kitDomToPng, kitRotationImage, kitChangeEventDisabled + optional peer deps - #8
Merged
Conversation
…Disabled + optional peer deps - kitDomToPng: replace void IIFE inside Promise constructor with a plain for-loop — avoids swallowed rejections from domtoimage.toPng(). - kitRotationImage: register image.onload before setting src (simpler, no setTimeout indirection). - kitChangeEventDisabled: read the signal directly instead of abusing update() for a DOM side-effect. - Add peerDependenciesMeta with optional:true for feature-scoped peers (preferences, status-bar, in-app-review, brotherprint, dom-to-image-more) so apps that don't use those features won't see npm warnings. Co-Authored-By: rdlabo <sakakibara@rdlabo.jp>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for rdlabo-ionic-angular-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
コミット
4c34b8aのレビューで指摘した4点を修正。kitDomToPng— void IIFE in Promise constructor → plain loopvoid (async () => { ... })()inside a Promise constructor swallows rejections fromdomtoimage.toPng(). A plainforloop propagates errors normally.kitRotationImage— simplifyimage.onloadregistrationRegister
onloadbefore settingsrc(works even for cached images). NosetTimeoutindirection needed.kitChangeEventDisabled— direct read instead ofupdateside-effectupdate()is for transforming the signal value; here the returned reference is unchanged and the DOM mutation is a side-effect. Direct read is clearer.peerDependenciesMeta— feature-scoped peers marked optionalAdds
"optional": truefor@capacitor/preferences,@capacitor/status-bar,@capacitor-community/in-app-review,@rdlabo/capacitor-brotherprint,dom-to-image-moreso apps that don't use theme/review/printer features won't see npm warnings.Link to Devin session: https://app.devin.ai/sessions/56d6f0b6efea45b594241ffd5e2ba916