feat(kit): add offline mutation controls and local reset - #76
Merged
Conversation
✅ Deploy Preview for rdlabo-ionic-angular-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
オフライン保存の有効・無効をプロダクトから切り替えられる共通機構と、破損時にローカルオフラインデータを明示的に初期化するcold-start APIをKitへ追加します。
オフライン読み込みは常に維持し、保存を無効化した場合だけ新規Outbox受付を停止して通常のHTTP transportへ切り替えます。
変更内容
背景
プロダクトごとに設定・enqueue受付・reset lifecycleを実装すると、設定切替中の遅延enqueueや初期化競合、部分削除後の誤った成功扱いが再発します。Outbox commitとcold bootstrapという大本の境界をKitが所有し、横展開時も同じ安全性を利用できるようにします。
利用者・運用への影響
検証
npm run lintpassednpm run test:offline-types:nonstrictpassedgit diff --checkpassed補足
native SQLite pluginのreload・delete lifecycleはunit mockで検証しています。リリース前にiOS/Android実機でのreset smoke testを推奨します。