Add shared browser PDF output helpers - #74
Merged
Conversation
✅ Deploy Preview for rdlabo-ionic-angular-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rdlabo
marked this pull request as ready for review
August 14, 2026 05:04
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kitDownloadPdffor browser-safe PDF downloads without navigating the current applicationkitPreviewGeneratedPdfto synchronously reserve a preview window before asynchronous PDF generation@rdlabo/ionic-angular-kit/printerWhy
foodlabel required repeated fixes around browser PDF delivery, including popup blocking, application-page navigation, premature link removal, object URL cleanup, and cleanup errors being reported as PDF generation failures. winecode and odss-mobile contain similar preview-window flows. This moves the browser lifecycle behavior into the shared kit while leaving PDF layout and application-specific UI in each consumer.
Error handling
Review
Validation
npx ng test kit --watch=false— 45 files / 837 tests passednpm run lint— passednpm run prebuild:kit— passedgit diff --check— passed